Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target tier policy: require ability to produce object code #115217

Closed

Conversation

davidtwco
Copy link
Member

Update target tier policy to require that targets be able to produce object code with a supported backend.

In the discussions around rust-lang/compiler-team#655, there was an open question of what exact requirement to make of tier three targets should be - require a test producing assembly which can be cross-compiled, or just require that it is possible at all. I've opted for the latter in this pull request, just because that's simpler to start with, once we have assembly tests for every existing target, we could update this.

r? @wesleywiser

Update target tier policy to require that targets be able to produce
object code with a supported backend.

Signed-off-by: David Wood <david@davidtw.co>
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2023
@the8472
Copy link
Member

the8472 commented Aug 26, 2023

once we have assembly tests for every existing target, we could update this.

I think we can require or at least recommend this from the start so it applies to new tier-3 platforms. We already have other rules that aren't enforced on legacy targets.

@davidtwco
Copy link
Member Author

Superseded by #118708.

@davidtwco davidtwco closed this Dec 7, 2023
@davidtwco davidtwco deleted the target-tier-policy-mcp-655 branch December 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants