Inject a libstd version, but not for stage3 #11523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The windows dist is made from stage 3 so I think this is wrong as written since we'll be distributing windows installations that don't inject the version number. Maybe we could configure the snapshot builder specially to not use version injection. |
|
Updated with a new ./configure flag that we can add to the snapshot building bots. |
We'll use this when building snapshots so we can upgrade freely, but all compilers will inject a version by default.
bors
added a commit
that referenced
this pull request
Jan 15, 2014
This should go back to the old behavior while preserving the snapshot ease.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 25, 2023
…nt-levels, r=xFrednet used_underscore_bindings: respect lint levels on the binding definition Fixes rust-lang#11520 Fixes rust-lang#947 Also ignores usages of `PhantomData` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should go back to the old behavior while preserving the snapshot ease.