Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a specialization for encoding byte arrays in rmeta #115287

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

saethlin
Copy link
Member

This specialization already exists for FileEncoder, but since EncodeContext is implemented by forwarding down to FileEncoder, using EncodeContext used to bypass the specialization.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2023
@cjgillot
Copy link
Contributor

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Aug 27, 2023

📌 Commit b233263 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2023
@bors
Copy link
Collaborator

bors commented Aug 27, 2023

⌛ Testing commit b233263 with merge 26d6c2a1979bc7838996a15d9d9c3e1f439e7e81...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [ui] tests/ui/lint/must_not_suspend/dedup.rs#drop_tracking_mir ... ok
test [ui] tests/ui/lint/lint-unnecessary-parens.rs ... ok
test [ui] tests/ui/lint/must_not_suspend/gated.rs ... ok
test [ui] tests/ui/lint/must_not_suspend/dedup.rs#no_drop_tracking ... ok
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
test [ui] tests/ui/lint/must_not_suspend/other_items.rs ... ok
test [ui] tests/ui/lint/lints-in-foreign-macros.rs ... ok
test [ui] tests/ui/lint/must_not_suspend/ref-drop-tracking.rs ... ok
test [ui] tests/ui/lint/must_not_suspend/ref.rs#drop_tracking ... ok
---

  local time: Mon Aug 28 00:01:58 UTC 2023
  network time: test [ui] tests/ui/lint/reasons-erroneous.rs ... ok
test [ui] tests/ui/lint/redundant-semicolon/item-stmt-semi.rs ... ok
Session terminated, killing shell... ...killed.
test [ui] tests/ui/lint/reasons-forbidden.rs ... ok
time="2023-08-28T00:01:58Z" level=error msg="error waiting for container: unexpected EOF"
##[error]The operation was canceled.

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2023
@saethlin
Copy link
Member Author

I'm guessing that the failure was spurious 🤞
@bors r=cjgillot rollup=never

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

📌 Commit b233263 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2023
@saethlin
Copy link
Member Author

Uh... so is it being tested or not? Also how is this blocked by a try build?

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

⌛ Testing commit b233263 with merge 3f8c8f5...

@bors
Copy link
Collaborator

bors commented Aug 28, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 3f8c8f5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2023
@bors bors merged commit 3f8c8f5 into rust-lang:master Aug 28, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 28, 2023
@saethlin saethlin deleted the more-specialer branch August 28, 2023 03:32
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3f8c8f5): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.5% [0.5%, 0.5%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)
-2.9% [-3.8%, -2.2%] 3
All ❌✅ (primary) -1.6% [-3.7%, 0.5%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.998s -> 631.903s (-0.02%)
Artifact size: 316.03 MiB -> 316.08 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants