-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a specialization for encoding byte arrays in rmeta #115287
Conversation
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
@bors r+ rollup=never |
⌛ Testing commit b233263 with merge 26d6c2a1979bc7838996a15d9d9c3e1f439e7e81... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
I'm guessing that the failure was spurious 🤞 |
💡 This pull request was already approved, no need to approve it again.
|
Uh... so is it being tested or not? Also how is this blocked by a try build? |
☀️ Test successful - checks-actions |
Finished benchmarking commit (3f8c8f5): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.998s -> 631.903s (-0.02%) |
This specialization already exists for FileEncoder, but since EncodeContext is implemented by forwarding down to FileEncoder, using EncodeContext used to bypass the specialization.