Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sys/hermit): remove obsolete network initialization #115309

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

mkroening
Copy link
Contributor

This function does not exist as of hermit-sys 0.4.1 (e38f246). Once std does not call this function, we can remove it entirely.

CC: @stlankes

@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 28, 2023
This function does not exist as of hermit-sys 0.4.1 [1].
Once std does not call this function, we can remove it entirely.

[1]: hermit-os/hermit-rs@e38f246#diff-a9b7fa816defab285f0d4fe69d4df4a0cbbcf1c89913000df3273aded949f257R10

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@cuviper
Copy link
Member

cuviper commented Aug 28, 2023

I haven't looked at hermit before -- how does hermit-sys enter the build? It would seem prudent to make sure the dependency is new enough, but I don't even see it in Cargo.lock.

@mkroening
Copy link
Contributor Author

Sorry for the confusion.

Hermit is a library operating system. That means users explicitly link their application against the whole OS to create a unikernel image, that can be run in VMs.

Here, hermit-abi contains the kernel's symbol names. The OS implementation of these symbols is built and linked to by hermit-sys (today renamed to just hermit). Only hermit-abi is checked into Rust's Cargo.lock for two reasons: not pollute the Cargo.lock with a full operating system, and let users update the OS independently.

So users have to update hermit-sys manually when updating their Rust toolchain and vice versa. This allows us to avoid committing to certain OS APIs.

@cuviper
Copy link
Member

cuviper commented Aug 28, 2023

OK, thanks for explaining!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 28, 2023

📌 Commit 5853c2b has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2023
@bors
Copy link
Contributor

bors commented Aug 29, 2023

⌛ Testing commit 5853c2b with merge fef2f59...

@bors
Copy link
Contributor

bors commented Aug 29, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing fef2f59 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 29, 2023
@bors bors merged commit fef2f59 into rust-lang:master Aug 29, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Aug 29, 2023
@mkroening mkroening deleted the hermit-net-init branch August 29, 2023 06:10
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fef2f59): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.1% [-4.1%, -2.2%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.903s -> 630.211s (0.05%)
Artifact size: 316.24 MiB -> 316.20 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants