remove reference counting headers from ~ #11535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
�thestinger and I discussed this. I have no problem with it. (If we do decide to put the TypeDesc back in later as part of GC support, we can put it at a negative offset known only to the GC and other privileged libstd libraries.) |
|
Can you add a test for #11532 as well? |
|
It'd also be nice for this to have |
|
You can also probably contain the transmutes in and out of impl<T> Repr<*Vec<T>> for ~[T] {} |
bors
added a commit
that referenced
this pull request
Jan 15, 2014
Unique pointers and vectors currently contain a reference counting
header when containing a managed pointer.
This `{ ref_count, type_desc, prev, next }` header is not necessary and
not a sensible foundation for tracing. It adds needless complexity to
library code and is responsible for breakage in places where the branch
has been left out.
The `borrow_offset` field can now be removed from `TyDesc` along with
the associated handling in the compiler.
Closes #9510
Closes #11533
|
Nice! Glad to see all this bloat disappear. |
Unique pointers and vectors currently contain a reference counting
header when containing a managed pointer.
This `{ ref_count, type_desc, prev, next }` header is not necessary and
not a sensible foundation for tracing. It adds needless complexity to
library code and is responsible for breakage in places where the branch
has been left out.
The `borrow_offset` field can now be removed from `TyDesc` along with
the associated handling in the compiler.
Closes #9510
Closes #11533
bors
added a commit
that referenced
this pull request
Jan 15, 2014
Unique pointers and vectors currently contain a reference counting
header when containing a managed pointer.
This `{ ref_count, type_desc, prev, next }` header is not necessary and
not a sensible foundation for tracing. It adds needless complexity to
library code and is responsible for breakage in places where the branch
has been left out.
The `borrow_offset` field can now be removed from `TyDesc` along with
the associated handling in the compiler.
Closes #9510
Closes #11533
|
Super awesome! |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
don't lint [`default_numeric_fallback`] on return and local assigned macro calls with type stated fixes: rust-lang#11535 changelog: don't lint [`default_numeric_fallback`] on return and local assigned macro calls with type stated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unique pointers and vectors currently contain a reference counting
header when containing a managed pointer.
This
{ ref_count, type_desc, prev, next }header is not necessary andnot a sensible foundation for tracing. It adds needless complexity to
library code and is responsible for breakage in places where the branch
has been left out.
The
borrow_offsetfield can now be removed fromTyDescalong withthe associated handling in the compiler.
Closes #9510
Closes #11533