Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format macro const literals with pretty printer #115485

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Format macro const literals with pretty printer #115485

merged 1 commit into from
Nov 7, 2023

Conversation

DaniPopes
Copy link
Contributor

Fixes #115295

@rustbot
Copy link
Collaborator

rustbot commented Sep 2, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 2, 2023
@klensy
Copy link
Contributor

klensy commented Sep 2, 2023

Some code around was recently changed in #115286.

@jackh726
Copy link
Member

jackh726 commented Oct 4, 2023

Is there a test we can add?

Code LGTM, but if there's a test we can add, I'd like to.

@DaniPopes DaniPopes force-pushed the rustdoc-macro-consts branch 2 times, most recently from c30e1d7 to 7cb3ff1 Compare October 10, 2023 17:06
@bors
Copy link
Contributor

bors commented Oct 15, 2023

☔ The latest upstream changes (presumably #116688) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

r? rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 22, 2023
@rustbot rustbot assigned notriddle and unassigned jackh726 Oct 22, 2023
@GuillaumeGomez
Copy link
Member

@fmease is the one who knows most about this so let's set them as reviewer.

r? @fmease

@rustbot rustbot assigned fmease and unassigned notriddle Nov 2, 2023
@fmease
Copy link
Member

fmease commented Nov 7, 2023

Thanks, that's a great improvement!
@bors r=jackh726,fmease rollup

@bors
Copy link
Contributor

bors commented Nov 7, 2023

📌 Commit 2b858b7 has been approved by jackh726,fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 7, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
@bors
Auto merge of rust-lang#117680 - matthiaskrgr:rollup-kgaa4ma, r=matth…
7adc89b 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#115485 (Format macro const literals with pretty printer)
 - rust-lang#117616 (warn when using an unstable feature with -Ctarget-feature)
 - rust-lang#117639 (Update books)
 - rust-lang#117675 (llvm-wrapper: Remove include of non-existant Vectorize.h)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cd5b5e0 into rust-lang:master Nov 7, 2023
11 checks passed
@rustbot rustbot added this to the 1.75.0 milestone Nov 7, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 7, 2023
@rust-timer
Unrolled build for rust-lang#115485
b80bfef 
Rollup merge of rust-lang#115485 - DaniPopes:rustdoc-macro-consts, r=jackh726,fmease

Format macro const literals with pretty printer

Fixes rust-lang#115295
@DaniPopes DaniPopes deleted the rustdoc-macro-consts branch December 28, 2023 19:55
celinval added a commit to celinval/rust-dev that referenced this pull request Jun 4, 2024
@github-actions @celinval @zhassan-aws
Automatic toolchain upgrade to nightly-2023-11-08 (rust-lang#2866)
70a7c6b 
Update Rust toolchain from nightly-2023-11-07 to nightly-2023-11-08
without any other source changes.
This is an automatically generated pull request. If any of the CI checks
fail, manual intervention is required. In such a case, review the
changes at https://github.com/rust-lang/rust from
rust-lang@189d6c7
up to
rust-lang@7adc89b.
The log for this commit range is:
rust-lang@7adc89b69b Auto merge of
rust-lang#117680 - matthiaskrgr:rollup-kgaa4ma, r=matthiaskrgr
rust-lang@518fe492f1 Rollup merge of
rust-lang#117675 - zmodem:vectorize_h, r=durin42
rust-lang@f6f6fd1d1a Rollup merge of
rust-lang#117639 - rustbot:docs-update, r=ehuss
rust-lang@f8c67704f2 Rollup merge of
rust-lang#117616 - RalfJung:unstable-target-features, r=compiler-errors
rust-lang@cd5b5e08fe Rollup merge of
rust-lang#115485 - DaniPopes:rustdoc-macro-consts, r=jackh726,fmease
rust-lang@118a2deea5 Auto merge of
rust-lang#117617 - Urgau:bump-libc-0.2.150, r=Mark-Simulacrum
rust-lang@84abf837b8 manually bless a
wasm-only test
rust-lang@752a6132e5 llvm-wrapper: Remove
include of non-existant Vectorize.h
rust-lang@9bd71afb90 Auto merge of
rust-lang#115904 - notriddle:notriddle/preload-bold, r=GuillaumeGomez
rust-lang@187d1afa9d Auto merge of
rust-lang#117297 - clubby789:fn-trait-missing-paren, r=TaKO8Ki
rust-lang@61a3eea804 Auto merge of
rust-lang#117229 - matthewjasper:thir-unsafeck-fixes, r=cjgillot
rust-lang@114f1f6838 Auto merge of
rust-lang#117610 - compiler-errors:object-hmm, r=aliemjay
rust-lang@504f63efb0 Auto merge of
rust-lang#117418 - compiler-errors:better_error_body, r=oli-obk
rust-lang@4e0fb98a5c Auto merge of
rust-lang#117006 - estebank:issue-69512, r=compiler-errors
rust-lang@f926031ea5 When not finding
assoc fn on type, look for builder fn
rust-lang@7b97a5ca84 Auto merge of
rust-lang#117511 - gurry:117406-err-packed-structs, r=compiler-errors
rust-lang@5a9f07cc97 Build a better MIR
body when errors are encountered
rust-lang@171d5587ca Don't instantiate
the binder twice when assembling object candidate
rust-lang@24e14dd8b4 Only check
predicates for late-bound non-lifetime vars in object candidate assembly
rust-lang@bf65e3bddb Update books
rust-lang@868de8e76b Visit patterns in
THIR let expressions
rust-lang@2b59992736 Add suggestion to
THIR unsafe_op_in_unsafe_fn lint
rust-lang@2b2c0f9886 Allow tests with
rust-rustfix and revisions
rust-lang@931692fa13 Recognise thread
local statics in THIR unsafeck
rust-lang@b85c6835d0 warn when using an
unstable feature with -Ctarget-feature
rust-lang@15719a8c1d libc: bump
dependency to 0.2.150
rust-lang@4b3ece475d Emit explanatory
note for move errors in packed struct derives
rust-lang@904aceec7d Give a better
diagnostic for missing parens in Fn* bounds
rust-lang@2b858b7eb8 Format macro const
literals with pretty printer
rust-lang@2a92981301 rustdoc: stop
preloading Source Serif 4 Bold

Co-authored-by: celinval <celinval@users.noreply.github.com>
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.

Inconsistent rustdoc constant expansion from macro
9 participants
@DaniPopes @rustbot @klensy @jackh726 @bors @cjgillot @GuillaumeGomez @fmease @notriddle