Skip to content

Don't ICE on associated type projection without feature gate in new solver #115519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Don't ICE on associated type projection without feature gate in new solver #115519

merged 1 commit into from
Sep 5, 2023
+55 −1

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Sep 3, 2023 •
edited
Loading

Self-explanatory, we should avoid ICEs when the feature gate is not enabled. Continue to ICE when the feature gate is enabled, though.

Fixes #115500

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr
Copy link
Contributor

lcnr commented Sep 4, 2023

r? @lcnr

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

📌 Commit 8c667fe has been approved by lcnr

It is now in the queue for this repository.

@rustbot rustbot assigned lcnr and unassigned cjgillot Sep 4, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit 8c667fe with merge bea21bdcbc33a2b5d56d7ae874cb47a9fca8222e...

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2023
@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    0: error decoding response body: operation timed out
    1: operation timed out

Stack backtrace:
   0: backtrace::backtrace::dbghelp::trace
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\dbghelp.rs:98
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:66
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:66
   2: backtrace::backtrace::trace<anyhow::backtrace::capture::impl$4::create::closure_env$0>
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:53
   3: anyhow::backtrace::capture::Backtrace::create
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\backtrace.rs:216
   4: anyhow::backtrace::capture::Backtrace::capture
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\backtrace.rs:204
   5: anyhow::error::impl$1::from<reqwest::error::Error>
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\error.rs:551
   6: opt_dist::environment::windows::impl$1::prepare_rustc_perf
             at /rustc/bea21bdcbc33a2b5d56d7ae874cb47a9fca8222e/src\tools\opt-dist\src\environment\windows.rs:46
   7: opt_dist::execute_pipeline::closure$0
             at /rustc/bea21bdcbc33a2b5d56d7ae874cb47a9fca8222e/src\tools\opt-dist\src\main.rs:37
   8: opt_dist::utils::with_log_group<opt_dist::execute_pipeline::closure_env$0,enum2$<core::result::Result<tuple$<>,anyhow::Error> > >
             at /rustc/bea21bdcbc33a2b5d56d7ae874cb47a9fca8222e/src\tools\opt-dist\src\utils\mod.rs:65
             at /rustc/bea21bdcbc33a2b5d56d7ae874cb47a9fca8222e/src\tools\opt-dist\src\main.rs:207
  10: core::ops::function::FnOnce::call_once
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
  11: std::sys_common::backtrace::__rust_begin_short_backtrace<enum2$<core::result::Result<tuple$<>,anyhow::Error> > (*)(),enum2$<core::result::Result<tuple$<>,anyhow::Error> > >
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\sys_common\backtrace.rs:154
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\rt.rs:166
  13: core::ops::function::FnOnce::call_once
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
  14: core::ops::function::FnOnce::call_once<std::rt::lang_start::closure_env$0<enum2$<core::result::Result<tuple$<>,anyhow::Error> > >,tuple$<> >
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\rt.rs:166
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library\std\src\rt.rs:148
  16: std::panicking::try::do_call
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library\std\src\panicking.rs:524
  17: std::panicking::try

@matthiaskrgr
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2023
@bors
Copy link
Collaborator

bors commented Sep 4, 2023

⌛ Testing commit 8c667fe with merge d697b4848410adfd1b1e6a53d5c97b051a65dc25...

@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    0: error decoding response body: operation timed out
    1: operation timed out

Stack backtrace:
   0: backtrace::backtrace::dbghelp::trace
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\dbghelp.rs:98
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:66
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:66
   2: backtrace::backtrace::trace<anyhow::backtrace::capture::impl$4::create::closure_env$0>
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\backtrace-0.3.69\src\backtrace\mod.rs:53
   3: anyhow::backtrace::capture::Backtrace::create
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\backtrace.rs:216
   4: anyhow::backtrace::capture::Backtrace::capture
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\backtrace.rs:204
   5: anyhow::error::impl$1::from<reqwest::error::Error>
             at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\anyhow-1.0.75\src\error.rs:551
   6: opt_dist::environment::windows::impl$1::prepare_rustc_perf
             at /rustc/d697b4848410adfd1b1e6a53d5c97b051a65dc25/src\tools\opt-dist\src\environment\windows.rs:46
   7: opt_dist::execute_pipeline::closure$0
             at /rustc/d697b4848410adfd1b1e6a53d5c97b051a65dc25/src\tools\opt-dist\src\main.rs:37
   8: opt_dist::utils::with_log_group<opt_dist::execute_pipeline::closure_env$0,enum2$<core::result::Result<tuple$<>,anyhow::Error> > >
             at /rustc/d697b4848410adfd1b1e6a53d5c97b051a65dc25/src\tools\opt-dist\src\utils\mod.rs:65
             at /rustc/d697b4848410adfd1b1e6a53d5c97b051a65dc25/src\tools\opt-dist\src\main.rs:207
  10: core::ops::function::FnOnce::call_once
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
  11: std::sys_common::backtrace::__rust_begin_short_backtrace<enum2$<core::result::Result<tuple$<>,anyhow::Error> > (*)(),enum2$<core::result::Result<tuple$<>,anyhow::Error> > >
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\sys_common\backtrace.rs:154
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\rt.rs:166
  13: core::ops::function::FnOnce::call_once
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\core\src\ops\function.rs:250
  14: core::ops::function::FnOnce::call_once<std::rt::lang_start::closure_env$0<enum2$<core::result::Result<tuple$<>,anyhow::Error> > >,tuple$<> >
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57\library\std\src\rt.rs:166
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library\std\src\rt.rs:148
  16: std::panicking::try::do_call
             at /rustc/680cdf8168a906b4ea80af673c64e4a16f77be57/library\std\src\panicking.rs:524
  17: std::panicking::try

@bors
Copy link
Collaborator

bors commented Sep 4, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 4, 2023
@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2023

@bors retry

GitHub incident

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 4, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 4, 2023
@matthiaskrgr
Rollup merge of rust-lang#115519 - compiler-errors:next-solver-assoc-…
7f93014 
…ice, r=lcnr

Don't ICE on associated type projection without feature gate in new solver

Self-explanatory, we should avoid ICEs when the feature gate is not enabled. Continue to ICE when the feature gate *is* enabled, though.

Fixes rust-lang#115500
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 4, 2023
Closed
@bors
Copy link
Collaborator

bors commented Sep 5, 2023

⌛ Testing commit 8c667fe with merge 40fa759ffe0e512cab456e73c72504fed48b0fb5...

@bors
Copy link
Collaborator

bors commented Sep 5, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744)
##[error]Can't use 'tar -xzf' extract archive file: /gha/_work/_actions/_temp_90850faf-cb89-4ad9-b555-9e5dd0d6d950/05ce4893-71a8-4483-a349-7fd631a77536.tar.gz. return code: 2.

@compiler-errors
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2023
@bors
Auto merge of rust-lang#115553 - matthiaskrgr:rollup-c0045hz, r=matth…
8cfaf70 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115353 (Emit error instead of ICE when optimized MIR is missing)
 - rust-lang#115488 (Take `&mut Results` in `ResultsVisitor`)
 - rust-lang#115492 (Allow `large_assignments` for Box/Arc/Rc initialization)
 - rust-lang#115519 (Don't ICE on associated type projection without feature gate in new solver)
 - rust-lang#115534 (Expose more information with DefId in smir)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5e6aa3 into rust-lang:master Sep 5, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

ICE: "associated const projection is not supported yet"
8 participants
@compiler-errors @rustbot @lcnr @bors @rust-log-analyzer @matthiaskrgr @ehuss @cjgillot