Skip to content

Conversation

coastalwhite
Copy link
Contributor

This bumps the version of the stdarch submodule to the current master. Notably, it now includes intrinsics for the RISC-V Scalar Cryptographic and Bit Manipulation extensions.

r? @Amanieu

@rustbot
Copy link
Collaborator

rustbot commented Sep 6, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 6, 2023
@Amanieu
Copy link
Member

Amanieu commented Sep 6, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 6, 2023

📌 Commit 2b02142 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2023
@bors
Copy link
Collaborator

bors commented Sep 7, 2023

⌛ Testing commit 2b02142 with merge d5573d7...

@bors
Copy link
Collaborator

bors commented Sep 7, 2023

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing d5573d7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2023
@bors bors merged commit d5573d7 into rust-lang:master Sep 7, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d5573d7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
-1.4% [-2.3%, -0.5%] 2
Improvements ✅
(secondary)
-2.2% [-2.3%, -2.2%] 3
All ❌✅ (primary) -1.4% [-2.3%, -0.5%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.1%, 2.4%] 14
Regressions ❌
(secondary)
1.8% [1.4%, 2.0%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [1.1%, 2.4%] 14

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.138s -> 629.234s (0.17%)
Artifact size: 317.88 MiB -> 317.83 MiB (-0.02%)

@coastalwhite coastalwhite deleted the bump-stdarch-riscv-intrinsics branch September 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants