-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow library features to be marked internal as well #115623
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1744,13 +1744,10 @@ rustc_queries! { | |
desc { |tcx| "computing crate imported by `{}`", tcx.def_path_str(def_id) } | ||
} | ||
|
||
query lib_features(_: ()) -> &'tcx LibFeatures { | ||
arena_cache | ||
desc { "calculating the lib features map" } | ||
} | ||
query defined_lib_features(_: CrateNum) -> &'tcx [(Symbol, Option<Symbol>)] { | ||
query lib_features(_: CrateNum) -> &'tcx LibFeatures { | ||
desc { "calculating the lib features defined in a crate" } | ||
separate_provide_extern | ||
arena_cache | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I consolidated this into one query -- it's not necessarily a requirement of this PR to do so, so if that's not desirable, I could revert it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is useful. Could you extract it in a standalone query? Or even a standalone PR, as there may be discussion on this PR. |
||
query stability_implications(_: CrateNum) -> &'tcx FxHashMap<Symbol, Symbol> { | ||
arena_cache | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all this method go in
rustc_passes::stability::check_unused_or_stable_features
?