compiletest: load supported sanitizers from target spec #115695

tmiasko · 2023-09-09T06:08:22Z

No description provided.

rustbot · 2023-09-09T06:08:30Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

src/tools/compiletest/src/header/tests.rs

oli-obk

r=me

oli-obk · 2023-09-11T10:22:41Z

src/tools/compiletest/src/header/tests.rs

+    fn channel(&mut self, s: &str) -> &mut Self {
+        self.channel = Some(s.to_owned());
+        self
+    }
+
+    fn host(&mut self, s: &str) -> &mut Self {
+        self.host = Some(s.to_owned());
+        self
+    }
+
+    fn target(&mut self, s: &str) -> &mut Self {
+        self.target = Some(s.to_owned());
+        self
+    }
+
+    fn stage_id(&mut self, s: &str) -> &mut Self {
+        self.stage_id = Some(s.to_owned());
+        self
+    }
+
+    fn llvm_version(&mut self, s: &str) -> &mut Self {
+        self.llvm_version = Some(s.to_owned());
+        self
+    }
+
+    fn git_hash(&mut self, b: bool) -> &mut Self {
+        self.git_hash = b;
+        self
+    }
+
+    fn system_llvm(&mut self, s: bool) -> &mut Self {
+        self.system_llvm = s;
+        self
+    }


You could derive all these similarly to how I did it in https://github.com/rust-lang/rust/pull/114104/files

bors · 2023-09-19T04:48:15Z

☔ The latest upstream changes (presumably #115644) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2023-09-21T13:34:18Z

@bors r+

bors · 2023-09-21T13:34:21Z

📌 Commit 34c248d has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-21T16:00:59Z

⌛ Testing commit 34c248d with merge 77fc4bf...

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

bors · 2023-09-21T16:29:59Z

💔 Test failed - checks-actions

oli-obk · 2023-09-22T09:35:55Z

@bors r+

bors · 2023-09-22T09:35:56Z

📌 Commit c4c4766 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-22T14:51:28Z

⌛ Testing commit c4c4766 with merge 4b8b80e...

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

bors · 2023-09-22T15:19:31Z

💔 Test failed - checks-actions

tmiasko · 2023-09-22T17:08:28Z

Updated a few more codgen tests.

@bors r=oli-obk

bors · 2023-09-22T17:08:30Z

📌 Commit 9090ed8 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-22T18:01:59Z

⌛ Testing commit 9090ed8 with merge 5dfdad5...

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

bors · 2023-09-22T19:56:59Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-09-22T19:57:04Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tmiasko · 2023-09-22T20:07:53Z

@bors retry failed without logs

bors · 2023-09-23T00:25:17Z

⌛ Testing commit 9090ed8 with merge 55b5c7b...

bors · 2023-09-23T02:23:38Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 55b5c7b to master...

rust-timer · 2023-09-23T03:46:48Z

Finished benchmarking commit (55b5c7b): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.5%]	6
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.8%, 3.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.258s -> 634.016s (-0.04%)
Artifact size: 317.45 MiB -> 317.53 MiB (0.02%)

rustbot assigned oli-obk Sep 9, 2023

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 9, 2023

tmiasko mentioned this pull request Sep 9, 2023

Fix sanitize/cfg.rs test #115673

Merged

This comment has been minimized.

Sign in to view

tmiasko force-pushed the compiletest-supported-sanitizers branch from ee54cfc to a6cbb5c Compare September 9, 2023 06:25

tmiasko commented Sep 9, 2023

View reviewed changes

src/tools/compiletest/src/header/tests.rs Outdated Show resolved Hide resolved

tmiasko force-pushed the compiletest-supported-sanitizers branch 2 times, most recently from dd69dc8 to 7f85c99 Compare September 10, 2023 11:48

oli-obk approved these changes Sep 11, 2023

View reviewed changes

tmiasko added 3 commits September 21, 2023 12:24

compiletest: use builder pattern to construct Config in tests

bc7bb3c

compiletest: load supported sanitizers from target spec

64e27cb

compiletest: load supports-xray from target spec

34c248d

tmiasko force-pushed the compiletest-supported-sanitizers branch from 7f85c99 to 34c248d Compare September 21, 2023 13:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2023

Auto merge of rust-lang#115695 - tmiasko:compiletest-supported-saniti…

77fc4bf

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 21, 2023

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 22, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023

Auto merge of rust-lang#115695 - tmiasko:compiletest-supported-saniti…

4b8b80e

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2023

tmiasko force-pushed the compiletest-supported-sanitizers branch from c4c4766 to a145a61 Compare September 22, 2023 16:01

Fix test on targets with crt-static default

9090ed8

tmiasko force-pushed the compiletest-supported-sanitizers branch from a145a61 to 9090ed8 Compare September 22, 2023 16:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 22, 2023

Auto merge of rust-lang#115695 - tmiasko:compiletest-supported-saniti…

5dfdad5

…zers, r=oli-obk compiletest: load supported sanitizers from target spec

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2023

bors merged commit 55b5c7b into rust-lang:master Sep 23, 2023

rustbot added this to the 1.74.0 milestone Sep 23, 2023

tmiasko deleted the compiletest-supported-sanitizers branch September 23, 2023 06:52

compiletest: load supported sanitizers from target spec #115695

compiletest: load supported sanitizers from target spec #115695

Uh oh!

Conversation

tmiasko commented Sep 9, 2023

Uh oh!

rustbot commented Sep 9, 2023

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk left a comment

Choose a reason for hiding this comment

Uh oh!

oli-obk Sep 11, 2023

Choose a reason for hiding this comment

Uh oh!

bors commented Sep 19, 2023

Uh oh!

oli-obk commented Sep 21, 2023

Uh oh!

bors commented Sep 21, 2023

Uh oh!

bors commented Sep 21, 2023

Uh oh!

This comment has been minimized.

bors commented Sep 21, 2023

Uh oh!

oli-obk commented Sep 22, 2023

Uh oh!

bors commented Sep 22, 2023

Uh oh!

bors commented Sep 22, 2023

Uh oh!

This comment has been minimized.

bors commented Sep 22, 2023

Uh oh!

tmiasko commented Sep 22, 2023

Uh oh!

bors commented Sep 22, 2023

Uh oh!

bors commented Sep 22, 2023

Uh oh!

bors commented Sep 22, 2023

Uh oh!

rust-log-analyzer commented Sep 22, 2023

Uh oh!

tmiasko commented Sep 22, 2023

Uh oh!

bors commented Sep 23, 2023

Uh oh!

bors commented Sep 23, 2023

Uh oh!

rust-timer commented Sep 23, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!