compiletest: load supported sanitizers from target spec #115695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
tmiasko
force-pushed
the
compiletest-supported-sanitizers
branch
from
ee54cfc
to
a6cbb5c
Compare
tmiasko
commented
Sep 9, 2023
tmiasko
force-pushed
the
compiletest-supported-sanitizers
branch
2 times, most recently
from
dd69dc8
to
7f85c99
Compare
oli-obk
approved these changes
Sep 11, 2023
Comment on lines
+68
to
+101
| fn channel(&mut self, s: &str) -> &mut Self { | ||
| self.channel = Some(s.to_owned()); | ||
| self | ||
| } | ||
|
|
||
| fn host(&mut self, s: &str) -> &mut Self { | ||
| self.host = Some(s.to_owned()); | ||
| self | ||
| } | ||
|
|
||
| fn target(&mut self, s: &str) -> &mut Self { | ||
| self.target = Some(s.to_owned()); | ||
| self | ||
| } | ||
|
|
||
| fn stage_id(&mut self, s: &str) -> &mut Self { | ||
| self.stage_id = Some(s.to_owned()); | ||
| self | ||
| } | ||
|
|
||
| fn llvm_version(&mut self, s: &str) -> &mut Self { | ||
| self.llvm_version = Some(s.to_owned()); | ||
| self | ||
| } | ||
|
|
||
| fn git_hash(&mut self, b: bool) -> &mut Self { | ||
| self.git_hash = b; | ||
| self | ||
| } | ||
|
|
||
| fn system_llvm(&mut self, s: bool) -> &mut Self { | ||
| self.system_llvm = s; | ||
| self | ||
| } |
There was a problem hiding this comment.
You could derive all these similarly to how I did it in https://github.com/rust-lang/rust/pull/114104/files
|
☔ The latest upstream changes (presumably #115644) made this pull request unmergeable. Please resolve the merge conflicts. |
tmiasko
force-pushed
the
compiletest-supported-sanitizers
branch
from
7f85c99
to
34c248d
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 21, 2023
…zers, r=oli-obk compiletest: load supported sanitizers from target spec
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r+ |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…zers, r=oli-obk compiletest: load supported sanitizers from target spec
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
tmiasko
force-pushed
the
compiletest-supported-sanitizers
branch
from
c4c4766
to
a145a61
Compare
tmiasko
force-pushed
the
compiletest-supported-sanitizers
branch
from
a145a61
to
9090ed8
Compare
|
Updated a few more codgen tests. @bors r=oli-obk |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 22, 2023
…zers, r=oli-obk compiletest: load supported sanitizers from target spec
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry failed without logs |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (55b5c7b): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 634.258s -> 634.016s (-0.04%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.