-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove verbose_generic_activity_with_arg
#115736
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
This comment has been minimized.
This comment has been minimized.
r? @wesleywiser as you reviewed the PR that added this function |
tcx.sess.time(name, || pass.run_pass(tcx, body)); | ||
tcx.sess | ||
.prof | ||
.generic_activity_with_arg("mir_pass", name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you leave the pass name as activity name? body.source.def_id()
can be used as arg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should work, but they should gain a mir_
prefix to fit with the profiling naming scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, no objections.
r=me with build passing
@bors r=wesleywiser |
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115736 (Remove `verbose_generic_activity_with_arg`) - rust-lang#115771 (cleanup leftovers of const_err lint) - rust-lang#115798 (add helper method for finding the one non-1-ZST field) - rust-lang#115812 (Merge settings.css into rustdoc.css) - rust-lang#115815 (fix: return early when has tainted in mir pass) - rust-lang#115816 (Disabled socketpair for Vita) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#115736 - Zoxc:time-cleanup, r=wesleywiser Remove `verbose_generic_activity_with_arg` This removes `verbose_generic_activity_with_arg` and changes users to `generic_activity_with_arg`. This keeps the output of `-Z time` readable while these repeated events are still available with the self profiling mechanism.
Remove `verbose_generic_activity_with_arg` This removes `verbose_generic_activity_with_arg` and changes users to `generic_activity_with_arg`. This keeps the output of `-Z time` readable while these repeated events are still available with the self profiling mechanism.
This removes
verbose_generic_activity_with_arg
and changes users togeneric_activity_with_arg
. This keeps the output of-Z time
readable while these repeated events are still available with the self profiling mechanism.