Rollup of 6 pull requests #115909

Dylan-DPC · 2023-09-17T11:23:27Z

Successful merges:

Remove Drop impl of mpsc Receiver and (Sync)Sender #114965 (Remove Drop impl of mpsc Receiver and (Sync)Sender)
make Debug impl for ascii::Char match that of char #115434 (make Debug impl for ascii::Char match that of char)
Stabilize the Saturating type #115477 (Stabilize the Saturating type)
add diagnostic for raw identifiers in format string #115611 (add diagnostic for raw identifiers in format string)
improve PassMode docs #115654 (improve PassMode docs)
Migrate compiler/rustc_hir_typeck/src/callee.rs to translatable diagnostics #115862 (Migrate compiler/rustc_hir_typeck/src/callee.rs to translatable diagnostics)

r? @ghost
@rustbot modify labels: rollup

Also stabilizes saturating_int_assign_impl, rust-langgh-92354. And also make pub fns const where the underlying saturating_* fns became const in the meantime since the Saturating type was created.

Remove Drop impl of mpsc Receiver and (Sync)Sender This change removes the empty `Drop` implementations for `mpsc::Receiver`, `mpsc::Sender` and `mpsc::SyncSender`. These implementations do not specify `#[may_dangle]`, so by removing them we make `mpsc` types play nice with drop check. This was previously attempted in [rust-lang#105243](rust-lang#105243 (comment)) but then [abandoned due to a test failure](rust-lang#105243 (comment)). I've aligned the test with those for `Mutex` and `RwLock`.

…olnay make `Debug` impl for `ascii::Char` match that of `char` # Objective use a more recognisable format for the `Debug` impl on `ascii::Char` than the derived one based off the enum variants. The alogorithm used is the following: - escape `ascii::Char::{Null, CharacterTabulation, CarraigeReturn, LineFeed, ReverseSolidus, Apostrophe}` to `'\0'`, `'\t'`, `'\r'`, `'\n'`, `'\\'` and `'\''` respectively. these are the same escape codes as `<char as Debug>::fmt` uses. - if `u8::is_ascii_control` is false, print the character wrapped in single quotes. - otherwise, print in the format `'\xAB'` where `A` and `B` are the hex nibbles of the byte. (`char` uses unicode escapes and this seems like the corresponding ascii format). Tracking issue: rust-lang#110998

…=dtolnay Stabilize the `Saturating` type Closes rust-lang#87920 Closes rust-lang#92354 Stabilization report rust-lang#87920 (comment) FCP rust-lang#87920 (comment)

…=compiler-errors add diagnostic for raw identifiers in format string Format strings don't support raw identifiers (e.g. `format!("{r#type}")`), but they do support keywords in the format string directly (e.g. `format!("{type}")`). This PR improves the error output when attempting to use a raw identifier in a format string and adds a machine-applicable suggestion to remove the `r#`. fixes rust-lang#115466

…r-errors improve PassMode docs

…ble, r=compiler-errors Migrate `compiler/rustc_hir_typeck/src/callee.rs` to translatable diagnostics

Dylan-DPC · 2023-09-17T12:18:52Z

@bors r+ rollup=never p=5

bors · 2023-09-17T12:18:53Z

📌 Commit f082f1d has been approved by Dylan-DPC

It is now in the queue for this repository.

bors · 2023-09-17T13:31:52Z

⌛ Testing commit f082f1d with merge db9c21f...

bors · 2023-09-17T15:20:29Z

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing db9c21f to master...

rust-timer · 2023-09-17T15:22:13Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#114965	Remove Drop impl of mpsc Receiver and (Sync)Sender	`16f21d22ceaeb506c435f2b6fc1779457522437b` (link)
#115434	make `Debug` impl for `ascii::Char` match that of `char`	`f596925e4d074a9f0efe671306860ee6e0e79e1e` (link)
#115477	Stabilize the `Saturating` type	`d82415e199f6d3c8279a3e32222d924eb9249975` (link)
#115611	add diagnostic for raw identifiers in format string	`38ae7040bb7b1f2929ca6f18b269a4b99e3121e7` (link)
#115654	improve PassMode docs	`aafc48bf119a9afdfa6abad9a4bfe1e135682d39` (link)
#115862	Migrate `compiler/rustc_hir_typeck/src/callee.rs` to transl…	`f5179788b83e6eb75df581a6dfa6491377f07609` (link)

previous master: 8ed1d4a02d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-09-17T16:42:24Z

Finished benchmarking commit (db9c21f): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.6%	[-1.0%, -0.5%]	6
Improvements ✅ (secondary)	-1.1%	[-1.5%, -0.4%]	19
All ❌✅ (primary)	-0.6%	[-1.0%, -0.5%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-2.1%	[-4.2%, -0.0%]	2
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.8%]	1
All ❌✅ (primary)	-2.1%	[-4.2%, -0.0%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Bootstrap: 636.351s -> 635.505s (-0.13%)
Artifact size: 318.44 MiB -> 318.39 MiB (-0.02%)

benschulz and others added 20 commits August 18, 2023 14:46

Remove Drop impl of mpsc Receiver and (Sync)Sender

a38ea96

fix Debug impl for AsciiChar

9c0e5eb

Unimpl Shl, ShlAssign, Shr and ShrAssign for Saturating

0eb4133

Stabilize the Saturating type (saturating_int_impl, rust-langgh-87920)

ad54426

Also stabilizes saturating_int_assign_impl, rust-langgh-92354. And also make pub fns const where the underlying saturating_* fns became const in the meantime since the Saturating type was created.

add diagnostic for raw identifiers in format string

d990eee

explain PassMode::Cast

7740476

clarify PassMode::Indirect as well

89139d4

fix gcc, cranelift build

29a4b7b

cannot have Direct for unsized types

3ee65c2

Migrate 'explicit destructor call' diagnostic

6e2adbf

Allow internal untranslatable diagnostic

9edeb19

Migrate 'rust-call incorrect arguments' diagnostic

b40f11c

Migrate 'invalid callee' diagnostic

cb9f666

Migrate 'missing fn lang items' diagnostic

8696ee8

Rollup merge of rust-lang#115477 - kellerkindt:stabilized_int_impl, r…

6011fd4

…=dtolnay Stabilize the `Saturating` type Closes rust-lang#87920 Closes rust-lang#92354 Stabilization report rust-lang#87920 (comment) FCP rust-lang#87920 (comment)

Rollup merge of rust-lang#115654 - RalfJung:pass-mode-cast, r=compile…

0c5f5b6

…r-errors improve PassMode docs

Rollup merge of rust-lang#115862 - clubby789:migrate-callee-translata…

f082f1d

…ble, r=compiler-errors Migrate `compiler/rustc_hir_typeck/src/callee.rs` to translatable diagnostics

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2023

bors merged commit db9c21f into rust-lang:master Sep 17, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 17, 2023

This was referenced Sep 17, 2023

Migrate diagnostics in hir_typeck/src/cast.rs #115879

Merged

rustc_hir_analysis: add a helper to check function the signature mismatches #115897

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #115909

Rollup of 6 pull requests #115909

Dylan-DPC commented Sep 17, 2023

Dylan-DPC commented Sep 17, 2023

bors commented Sep 17, 2023

bors commented Sep 17, 2023

bors commented Sep 17, 2023

rust-timer commented Sep 17, 2023

rust-timer commented Sep 17, 2023

Rollup of 6 pull requests #115909

Rollup of 6 pull requests #115909

Conversation

Dylan-DPC commented Sep 17, 2023

Dylan-DPC commented Sep 17, 2023

bors commented Sep 17, 2023

bors commented Sep 17, 2023

bors commented Sep 17, 2023

rust-timer commented Sep 17, 2023

rust-timer commented Sep 17, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size