-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustc_target/loongarch: Fix passing of transparent unions with only one non-ZST member #115987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ne non-ZST member This ensures that `MaybeUninit<T>` has the same ABI as `T` when passed through an `extern "C"` function. Fixes #115509
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ad36b5a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 633.382s -> 632.887s (-0.08%) |
This should really share code with the riscv ABI, having this all implemented twice is a pain. The ABIs are 100% identical, at least in their current Rust implementation. |
This ensures that
MaybeUninit<T>
has the same ABI asT
when passed through anextern "C"
function.Fixes #115509
r? @bjorn3