-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: add test cases, and fix, search tabs layout jank #115988
Conversation
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha Some changes occurred in GUI tests. |
This comment has been minimized.
This comment has been minimized.
96da64e
to
0adabd8
Compare
6641bcc
to
a630701
Compare
This comment has been minimized.
This comment has been minimized.
a630701
to
9fbee7d
Compare
@@ -2334,11 +2334,16 @@ ${item.displayPath}<span class="${type}">${name}</span>\ | |||
} | |||
|
|||
function makeTabHeader(tabNb, text, nbElems) { | |||
// https://blog.horizon-eda.org/misc/2020/02/19/ui.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice read. Could you add a small explanation nonetheless in case the website disappears? Something like \u{2007} is a unicode character the same size as a digit to keep alignment locked
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from my nit, it's a really nice improvement, thanks!
Thanks! r=me once CI pass. |
@bors r=GuillaumeGomez |
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#115566 (clean up unneeded `ToPredicate` impls) - rust-lang#115962 (coverage: Remove debug code from the instrumentor) - rust-lang#115988 (rustdoc: add test cases, and fix, search tabs layout jank) - rust-lang#115991 (Ensure `build/tmp` exists in `rustdoc_themes::get_themes`) - rust-lang#115997 (RELEASES.md: Add missing patch releases) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#115988 - notriddle:notriddle/search-tab-layout, r=GuillaumeGomez rustdoc: add test cases, and fix, search tabs layout jank ## Before ### Resizing https://github.com/rust-lang/rust/assets/1593513/24bb5f2b-f6bd-4ed8-91e1-f9ff63d1acee ### Typing https://github.com/rust-lang/rust/assets/1593513/145f53e1-42eb-4b2a-adba-7c9ab44b0aa4 ## After ### Resizing https://github.com/rust-lang/rust/assets/1593513/acc10a55-e83e-43e6-8604-5dfcb9ae3141 ### Typing https://github.com/rust-lang/rust/assets/1593513/09d6d389-e24f-428f-933f-83d9075f15a2
Before
Resizing
Screen.Recording.2023-09-19.at.20.36.43.mov
Typing
Screen.Recording.2023-09-19.at.20.44.43.mov
After
Resizing
Screen.Recording.2023-09-19.at.20.50.52.mov
Typing
Screen.Recording.2023-09-19.at.20.49.51.mov