-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include destruction scopes in THIR #116170
Don't include destruction scopes in THIR #116170
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…n-scopes, r=<try> Don't include destruction scopes in THIR They are not used by anyone, and add memory/performance overhead.
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
a792217
to
46eebff
Compare
This comment has been minimized.
This comment has been minimized.
46eebff
to
9c98b1e
Compare
Finished benchmarking commit (37859fe): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.717s -> 631.452s (-0.04%) |
Nothing significant is probably expected for a small change to a not that hot part of the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay for me, but I'm not sure what those scopes are, so re-rolling.
r? @bjorn3 maybe?
I'm not familiar with THIR either... |
Maybe @cjgillot ? |
IIRC, there has been recent work on destruction scopes by @nikomatsakis and @dingxiangfei2009. Can you two help with review? |
signaling an ask for a t-lang feedback cc: @nikomatsakis @rustbot label T-lang |
☔ The latest upstream changes (presumably #118143) made this pull request unmergeable. Please resolve the merge conflicts. |
They are not used by anyone, and add memory/performance overhead.
9c98b1e
to
43adf41
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1dfb228): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.475s -> 671.155s (0.10%) |
last usages removed by rust-lang#116170
…ler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
…ler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
…ler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
…ler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
Rollup merge of rust-lang#120386 - klensy:destruction_scopes, r=compiler-errors ScopeTree: remove destruction_scopes as unused last usages removed by rust-lang#116170 Unused, but still presented in memory at `t-gmax` (in DHAT termonology)
They are not used by anyone, and add memory/performance overhead.