Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_arena overhaul #116224

Merged
merged 9 commits into from
Oct 1, 2023
Merged

rustc_arena overhaul #116224

merged 9 commits into from
Oct 1, 2023

Commits on Sep 28, 2023

  1. rustc_arena: tweak some comments.

    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    79b11f0 View commit details
    Browse the repository at this point in the history

  2. Remove some unnecessary lifetimes.

    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    a11f7e4 View commit details
    Browse the repository at this point in the history

  3. Inline and remove DroplessArena::grow_and_alloc. 

    It has a single callsite.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    0001edd View commit details
    Browse the repository at this point in the history

  4. Inline and remove TypedArena::ensure_capacity. 

    It has a single callsite.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    55de23e View commit details
    Browse the repository at this point in the history

  5. Remove unsafe from TypedArena::alloc_raw_slice. 

    There's no good reason for it.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    51edc21 View commit details
    Browse the repository at this point in the history

  6. Use Layout::new consistently in DroplessArena::alloc.

    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    98d97b7 View commit details
    Browse the repository at this point in the history

  7. Make DroplessArena::alloc call DroplessArena::alloc_raw. 

    They're very similar.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    25407bc View commit details
    Browse the repository at this point in the history

  8. Reduce grow_and_alloc_raw to a single call site. 

    The current structure is clumsy, calling `alloc_raw_without_grow` in one
function, and then if that fails, calling another function that calls
`alloc_raw_without_grow` again.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    55a1a52 View commit details
    Browse the repository at this point in the history

  9. Inline and remove DroplessArena::alloc_raw_without_grow. 

    It has a single call site. I find the code clearer with it gone.
    @nnethercote
    nnethercote committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    bb5344a View commit details
    Browse the repository at this point in the history