Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate move path tracking between borrowck and drop elaboration. #116300

Merged
merged 11 commits into from
Oct 24, 2023
Merged

Separate move path tracking between borrowck and drop elaboration. #116300

merged 11 commits into from
Oct 24, 2023

Commits on Oct 21, 2023

  1. Remove is_terminal_path. 

    That information is redundant. Is the path is terminal, `first_child` will
already be `None`.
    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    a8e56d0 View commit details
    Browse the repository at this point in the history

  2. Do not report errors from move path builder.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    8d53507 View commit details
    Browse the repository at this point in the history

  3. Avoid using a magic value for untracked locals.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    90e6d29 View commit details
    Browse the repository at this point in the history

  4. Stop computing error info in move path builder.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    4bedd7d View commit details
    Browse the repository at this point in the history

  5. Parametrize gather_moves by filter.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    252c647 View commit details
    Browse the repository at this point in the history

  6. Give collect_drop_flags and elaborate_drops closer structure.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    f038882 View commit details
    Browse the repository at this point in the history

  7. Do not create move paths that do not need dropping.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    c9c0c0c View commit details
    Browse the repository at this point in the history

  8. Remove on_all_drop_children_bits. 

    As drop elaboration only tracks places that need dropping, is has become
equivalent to `on_all_children_bits`.
    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    547af00 View commit details
    Browse the repository at this point in the history

  9. Use terse form for Fn bound.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    7ae1851 View commit details
    Browse the repository at this point in the history

  10. Remove redundant checks.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    abb723d View commit details
    Browse the repository at this point in the history

  11. Typo.

    @cjgillot
    cjgillot committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    c8f33ec View commit details
    Browse the repository at this point in the history