Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent formatting for args and attrs #11646

Closed
wants to merge 9 commits into from

Conversation

tweber12
Copy link
Contributor

No description provided.

@emberian
Copy link
Member

Needs a rebase.

adrientetar and others added 8 commits January 18, 2014 21:26
This fixes a regression introduced in
3d57b24.
…ching)

Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
This removes the `Primitive::{bits, bytes, is_signed}` methods and removes the operator trait constraints, for the reasons outlined below:

- The `Primitive::{bits, bytes}` associated functions were originally added to reflect the existing `BITS` and `BYTES` statics included in the numeric modules. These statics are only exist as a workaround for Rust's lack of CTFE, and should probably be deprecated in the future in favor of using the `std::mem::size_of` function (see rust-lang#11621).

- `Primitive::is_signed` seems to be of little utility and does not seem to be used anywhere in the Rust compiler or libraries. It is also rather ugly to call due to the `Option<Self>` workaround for rust-lang#8888.

- The operator trait constraints are already covered by the `Num` trait.
Fixes rust-lang#11559 (not that the manual couldn't use a review).
@tweber12 tweber12 closed this Jan 18, 2014
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 21, 2023
…th-the-lints!!, r=giraffate

Make `multiple_unsafe_ops_per_block` ignore await desugaring

The await desugaring contains two calls (`Poll::new_unchecked` and `get_context`) inside a single unsafe block. That violates the lint.

fixes rust-lang#11312

changelog: [`multiple_unsafe_ops_per_block`]: fix false positives in `.await`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants