-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow bootstrap cache path to be set by environment variable #116697
Conversation
This allows the bootstrap cache path to be set by the `RUSTC_BOOTSTRAP_CACHE` environment variable. Setting the bootstrap cache path to an external location can help to speed up builds in cases where the build directory is not kept between builds, e.g. in CI or other automated build systems.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clubby789 (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
FYI we at the OpenWrt packages feed recently merged a patch essentially the same as this one (openwrt/packages#22339). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of RUSTC_BOOTSTRAP_CACHE
env, it would be more appropriate to add a new field(something like bootstrap-cache
) to the build configuration under the [build]
section. That way we can document it too in config.example.toml
file.
☔ The latest upstream changes (presumably #116196) made this pull request unmergeable. Please resolve the merge conflicts. |
cc @jefferyto from triage: marking this PR as waiting-for-author due to merge conflicts. |
This will be implemented with #121976 |
Add an option to have an external download/bootstrap cache Follow up from rust-lang#116697 to address rust-lang#116697 (review)
Add an option to have an external download/bootstrap cache Follow up from rust-lang#116697 to address rust-lang#116697 (review)
Rollup merge of rust-lang#121976 - lu-zero:bootstrap-cache, r=onur-ozkan Add an option to have an external download/bootstrap cache Follow up from rust-lang#116697 to address rust-lang#116697 (review)
This allows the bootstrap cache path to be set by the
RUSTC_BOOTSTRAP_CACHE
environment variable.Setting the bootstrap cache path to an external location can help to speed up builds in cases where the build directory is not kept between builds, e.g. in CI or other automated build systems.