Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bootstrap cache path to be set by environment variable #116697

Closed
wants to merge 1 commit into from

Conversation

jefferyto
Copy link
Contributor

This allows the bootstrap cache path to be set by the RUSTC_BOOTSTRAP_CACHE environment variable.

Setting the bootstrap cache path to an external location can help to speed up builds in cases where the build directory is not kept between builds, e.g. in CI or other automated build systems.

This allows the bootstrap cache path to be set by the
`RUSTC_BOOTSTRAP_CACHE` environment variable.

Setting the bootstrap cache path to an external location can help to
speed up builds in cases where the build directory is not kept between
builds, e.g. in CI or other automated build systems.
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @clubby789 (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 13, 2023
@jefferyto
Copy link
Contributor Author

FYI we at the OpenWrt packages feed recently merged a patch essentially the same as this one (openwrt/packages#22339).

Copy link
Member

@onur-ozkan onur-ozkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of RUSTC_BOOTSTRAP_CACHE env, it would be more appropriate to add a new field(something like bootstrap-cache) to the build configuration under the [build] section. That way we can document it too in config.example.toml file.

@bors
Copy link
Contributor

bors commented Oct 17, 2023

☔ The latest upstream changes (presumably #116196) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxu
Copy link
Member

cc @jefferyto from triage: marking this PR as waiting-for-author due to merge conflicts.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
@onur-ozkan
Copy link
Member

This will be implemented with #121976

@onur-ozkan onur-ozkan closed this Mar 6, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2024
Add an option to have an external download/bootstrap cache

Follow up from rust-lang#116697 to address rust-lang#116697 (review)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 6, 2024
Add an option to have an external download/bootstrap cache

Follow up from rust-lang#116697 to address rust-lang#116697 (review)
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2024
Rollup merge of rust-lang#121976 - lu-zero:bootstrap-cache, r=onur-ozkan

Add an option to have an external download/bootstrap cache

Follow up from rust-lang#116697 to address rust-lang#116697 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants