Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP fix unsoundness via adjusting overlap check for some Pin impls #116706

Closed
wants to merge 1 commit into from
Closed

WIP fix unsoundness via adjusting overlap check for some Pin impls #116706

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Oct 13, 2023 •
edited
Loading

WIP fix for #85099, will write up a description w/ @lcnr when I'm back from traveling

r? lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 13, 2023
@compiler-errors
Copy link
Member Author

worth crater i guess

@bors try

@bors
Copy link
Contributor

bors commented Oct 13, 2023

⌛ Trying commit 9cff29e with merge 05d512a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2023
@bors
Auto merge of rust-lang#116706 - compiler-errors:pin-negate, r=<try>
05d512a 
WIP

WIP fix for rust-lang#85099, will write up a description w/ `@lcnr` when I'm at my computer

r? lcnr
@compiler-errors compiler-errors changed the title WIP WIP fix unsoundness via adjusting overlap check for some Pin impls Oct 13, 2023
@bors
Copy link
Contributor

bors commented Oct 13, 2023

☀️ Try build successful - checks-actions
Build commit: 05d512a (05d512a9fb18e1ec3df5d68214c469c0b58cafb6)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-116706 created and queued.
🤖 Automatically detected try build 05d512a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-116706 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-116706 is completed!
📊 7 regressed and 0 fixed (378027 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 17, 2023
@compiler-errors
Copy link
Member Author

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-116706/retry-regressed-list.txt

@craterbot
Copy link
Collaborator

👌 Experiment pr-116706-1 created and queued.
🤖 Automatically detected try build 05d512a
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2023
@compiler-errors
Copy link
Member Author

TODO: Create an example that fails in the new trait solver

@craterbot
Copy link
Collaborator

🚧 Experiment pr-116706-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-116706-1 is completed!
📊 1 regressed and 0 fixed (7 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 30, 2023
@lcnr lcnr added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2023
@compiler-errors
Copy link
Member Author

@lcnr: Feel free to open this change yourself, since you're probably more equipped to write up an FCP proposal for this. I don't have the time to write up anything for this alone.

@QuineDot QuineDot mentioned this pull request Mar 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @bors @craterbot @lcnr @rustbot