Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable missing_copy_implementations lint on non_exhaustive types #116812

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/rustc_lint/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,11 @@ impl<'tcx> LateLintPass<'tcx> for MissingCopyImplementations {
if type_implements_negative_copy_modulo_regions(cx.tcx, ty, param_env) {
return;
}
if def.is_variant_list_non_exhaustive()
|| def.variants().iter().any(|variant| variant.is_field_list_non_exhaustive())
{
return;
}

// We shouldn't recommend implementing `Copy` on stateful things,
// such as iterators.
Expand Down
25 changes: 25 additions & 0 deletions tests/ui/lint/missing-copy-implementations-non-exhaustive.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
// Test for issue #116766.
// Ensure that we don't suggest impl'ing `Copy` for a type if it or at least one
// of it's variants are marked as `non_exhaustive`.

// check-pass

#![deny(missing_copy_implementations)]

#[non_exhaustive]
pub enum MyEnum {
A,
}

#[non_exhaustive]
pub struct MyStruct {
foo: usize,
}

pub enum MyEnum2 {
#[non_exhaustive]
A,
B,
}

fn main() {}
Loading