Normalize when collecting TAITs in signature #116819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Ah, there's that stack overflow 🤣 |
oli-obk
reviewed
Oct 17, 2023
Comment on lines
-1
to
-2
| //! Test that we don't follow through projections to find | ||
| //! opaque types. |
There was a problem hiding this comment.
Change the comments to explain what the test is testing now (same for all the other tests)
|
I've reworked this a bit, but as a consequence, I think we need to consider all usages of a TAIT in a signature to be defining. I'll write a bit more about why later. @rustbot author |
rustbot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #117076) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm gonna put this on pause until we decide whether we even want to have the signature rule for TAITs @rustbot blocked |
rustbot
added
S-blocked
|
Don't think we're gonna go with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize before visiting when collecting opaques allowed to be defined by body.
r? oli-obk
Just putting this up for initial review, not super cleaned up yet.