Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a performance regression in obligation deduplication. #116826

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix a performance regression in obligation deduplication. #116826

merged 1 commit into from
Oct 17, 2023

Commits on Oct 17, 2023

  1. Fix a performance regression in obligation deduplication. 

    Commit 8378487 from rust-lang#114611 changed the location of an obligation
deduplication step in `opt_normalize_projection_type`. This meant that
deduplication stopped happening on one path where it was still
necessary, causing a couple of drastic performance regressions.

This commit moves the deduplication back to the old location. The good
news is that rust-lang#114611 had four commits and 8378487 was of minimal
importance, so the perf benefits from that PR remain.

Fixes rust-lang#116780, rust-lang#116797.
    @nnethercote
    nnethercote committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    91f2fbc View commit details
    Browse the repository at this point in the history