Suggest field typo through derefs #117110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
deref-field-suggestion
branch
2 times, most recently
from
5e56fb2 to
d3ceb6c
Compare
estebank
force-pushed
the
deref-field-suggestion
branch
from
d3ceb6c to
c715d93
Compare
b-naber
reviewed
Nov 15, 2023
| } | ||
| ty::Alias(ty::Opaque, _) => { | ||
| self.suggest_await_on_field_access(&mut err, ident, base, base_ty.peel_refs()); |
There was a problem hiding this comment.
nit: can you please extract this whole block to a function and not make suggest_await_on_field_access return a value, but instead put the functionality in suggest_await_on_field_access, that is responsible for the return value, in this function?
There was a problem hiding this comment.
I didn't mean that you should get rid of the has_label block, just that you either move the functionality that calculates has_label to its own function. As an alternative you could also just put the logic that was responsible for calculating the return value of suggest_await_on_field_access directly into the "has_label block" instead of making suggest_await_on_field_access have a return value.
There was a problem hiding this comment.
What do you think of the last commit instead? There's some duplication of the setting of the label, but less state to keep track of.
estebank
force-pushed
the
deref-field-suggestion
branch
from
c715d93 to
bd8b50a
Compare
Take into account implicit dereferences when suggesting fields. ``` error[E0609]: no field `longname` on type `Arc<S>` --> $DIR/suggest-field-through-deref.rs:10:15 | LL | let _ = x.longname; | ^^^^^^^^ help: a field with a similar name exists: `long_name` ``` CC rust-lang#78374 (comment)
When encountering a `Result<T, _>` or `Option<T>` where `T` has a field that's being accessed, suggest calling `.unwrap()` to get to the field.
estebank
force-pushed
the
deref-field-suggestion
branch
from
bd8b50a to
1ee37bf
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 18, 2023
…=b-naber Suggest field typo through derefs Take into account implicit dereferences when suggesting fields. ``` error[E0609]: no field `longname` on type `Arc<S>` --> $DIR/suggest-field-through-deref.rs:10:15 | LL | let _ = x.longname; | ^^^^^^^^ help: a field with a similar name exists: `long_name` ``` CC rust-lang#78374 (comment)
TaKO8Ki
added a commit
to TaKO8Ki/rust
that referenced
this pull request
Nov 18, 2023
…=b-naber Suggest field typo through derefs Take into account implicit dereferences when suggesting fields. ``` error[E0609]: no field `longname` on type `Arc<S>` --> $DIR/suggest-field-through-deref.rs:10:15 | LL | let _ = x.longname; | ^^^^^^^^ help: a field with a similar name exists: `long_name` ``` CC rust-lang#78374 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#116446 (Yeet `mir::Const::from_anon_const`) - rust-lang#116750 (Add Seek::seek_relative) - rust-lang#117110 (Suggest field typo through derefs) - rust-lang#117961 (Add `x suggest` entries for testing `mir-opt` and `coverage`) - rust-lang#118020 (Fix links to `From<{OwnedHandle, OwnedFd}> for std::process::Child{Stdin, Stdout, Stderr}` in 1.74 release notes) - rust-lang#118034 (bump few deps to fix unsoundness and drop few dup deps) r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Nov 18, 2023
…=b-naber Suggest field typo through derefs Take into account implicit dereferences when suggesting fields. ``` error[E0609]: no field `longname` on type `Arc<S>` --> $DIR/suggest-field-through-deref.rs:10:15 | LL | let _ = x.longname; | ^^^^^^^^ help: a field with a similar name exists: `long_name` ``` CC rust-lang#78374 (comment)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Rollup of 5 pull requests Successful merges: - rust-lang#116750 (Add Seek::seek_relative) - rust-lang#117110 (Suggest field typo through derefs) - rust-lang#117961 (Add `x suggest` entries for testing `mir-opt` and `coverage`) - rust-lang#118020 (Fix links to `From<{OwnedHandle, OwnedFd}> for std::process::Child{Stdin, Stdout, Stderr}` in 1.74 release notes) - rust-lang#118034 (bump few deps to fix unsoundness and drop few dup deps) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2023
Rollup merge of rust-lang#117110 - estebank:deref-field-suggestion, r=b-naber Suggest field typo through derefs Take into account implicit dereferences when suggesting fields. ``` error[E0609]: no field `longname` on type `Arc<S>` --> $DIR/suggest-field-through-deref.rs:10:15 | LL | let _ = x.longname; | ^^^^^^^^ help: a field with a similar name exists: `long_name` ``` CC rust-lang#78374 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account implicit dereferences when suggesting fields.
CC #78374 (comment)