Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #117135

Merged
merged 22 commits into from
Oct 24, 2023
Merged

Rollup of 8 pull requests #117135

merged 22 commits into from
Oct 24, 2023

Commits on Oct 14, 2023

  1. Derive Ord, PartialOrd and Hash for SocketAddr*

    ...instead of hand rolling impls, since
    1. It's nicer
    2. It fixes a buggy `Ord` impl of `SocketAddrV6`, which ignored half of the fields
    WaffleLapkin committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    963131e View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    5c13c69 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Configuration menu
    Copy the full SHA
    2bba98b View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    66a554b View commit details
    Browse the repository at this point in the history
  2. Add internal() method counterpart to stable()

    Note: We do not expect to provide internalizing methods for all
    StableMIR constructs. They exist only to help migrating efforts to allow
    users to mix StableMIR and internal constructs.
    celinval committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    f613b26 View commit details
    Browse the repository at this point in the history
  3. Remove unsafe and Rc

    celinval committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    421631a View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Configuration menu
    Copy the full SHA
    cb61816 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6cf9423 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    300d04d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ae86f59 View commit details
    Browse the repository at this point in the history
  5. Introduce -C instrument-coverage=branch to gate branch coverage

    This flag has to be used in combination with `-Zunstable-options`,
    and is added in advance of adding branch coverage instrumentation.
    Swatinem committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2b36547 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    68f5536 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    90e3aae View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f3d20be View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#116094 - Swatinem:coverage-branch-gate, r=w…

    …esleywiser
    
    Introduce `-C instrument-coverage=branch` to gate branch coverage
    
    This was extracted from rust-lang#115061 and can land independently from other coverage related work.
    
    The flag is unused for now, but is added in advance of adding branch coverage support.
    It is an unstable, nightly only flag that needs to be used in combination with `-Zunstable-options`, like so: `-Zunstable-options -C instrument-coverage=branch`.
    
    The goal is to develop branch coverage as an unstable opt-in feature first, before it matures and can be turned on by default.
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c07ff9c View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#116396 - obeis:hir-analysis-migrate-diagnos…

    …tics-7, r=oli-obk
    
    Migrate diagnostics in `rustc_hir_analysis/src/coherence/orphan.rs`
    
    r? ``@compiler-errors``
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f3e18e4 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#116714 - WaffleLapkin:order-the-order, r=jo…

    …shtriplett
    
    Derive `Ord`, `PartialOrd` and `Hash` for `SocketAddr*`
    
    Fixes rust-lang#116711
    
    The main pain of this PR is to fix the buggy impl of `Ord` for `SocketAddrV6`, which ignored half of the fields (while `PartialEq` is derived):
    https://github.com/rust-lang/rust/blob/4603f0b8afb495ae56cd4c8f70d5d478d906ac54/library/core/src/net/socket_addr.rs#L99-L106
    
    https://github.com/rust-lang/rust/blob/4603f0b8afb495ae56cd4c8f70d5d478d906ac54/library/core/src/net/socket_addr.rs#L676
    
    For me it looks like a simple copy-paste error made in rust-lang#72239 (copy from v4 impl) (cc `@hch12907),` as I don't see this behavior being mentioned anywhere on the PR and it also does not respect `cmp` trait "rules". I also do not see any reasons for those impls to _not_ be derived.
    
    It's a shame we did not notice this for 28 versions/3 years. I guess this is a bug fix, but I'm not sure what the process here should be.
    
    r? libs
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    845c414 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#116792 - JonasAlaif:renumber-fix, r=b-naber

    Avoid unnecessary renumbering during borrowck
    
    Currently, after renumbering there are always unused `RegionVid`s if the return type contains any regions, this is due to `visit_ty` being called twice on the same `Ty`: once with `TyContext::ReturnTy` and once with `TyContext::LocalDecl { local: _0 }`. This PR skips renumbering the first time around.
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    61ff4db View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#116841 - chenyukang:yukang-suggest-unwrap-e…

    …xpect, r=b-naber
    
    Suggest unwrap/expect for let binding type mismatch
    
    Found it when investigating rust-lang#116738
    I'm not sure whether it's a good style to suggest `unwrap`, seems it's may helpful for newcomers.
    
    rust-lang#116738 needs another fix to improve it.
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7a0a2d2 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#116943 - heiher:target-features, r=wesleywiser

    Add target features for LoongArch
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    84f0bef View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#117010 - celinval:smir-internal, r=oli-obk

    Add method to convert internal to stable constructs
    
    This is an alternative implementation to rust-lang#116999. I believe we can still improve the logic a bit here, but I wanted to see which direction we should go first.
    
    In this implementation, the API is simpler and we keep Tables somewhat private. The definition is still public though, since we have to expose the Stable trait. However, there's a cost of keeping another thread-local and using `Rc`, but I'm hoping it will be a small cost.
    
    r? ``@oli-obk``
    r? ``@spastorino``
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f131a0a View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#117127 - compiler-errors:incomplete, r=lqd

    Remove `#[allow(incomplete_features)]` from RPITIT/AFIT tests
    
    They've been unnecessary for a while.
    matthiaskrgr authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    060bdfd View commit details
    Browse the repository at this point in the history