Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary builds/rebuilds of rust-demangler #117197

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Avoid unnecessary builds/rebuilds of rust-demangler #117197

merged 2 commits into from
Oct 28, 2023

Commits on Oct 27, 2023

  1. Don't provide rust-demangler to run-make tests 

    The demangler was only needed by coverage tests, but those tests were migrated
into their own custom test mode in rust-lang#112300.

This avoids having to build the demangler just for run-make tests. It will
still be built as needed by run-coverage tests or for other purposes.
    @Zalathar
    Zalathar committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    be0d73a View commit details
    Browse the repository at this point in the history

  2. For run-coverage tests, build rust-demangler with the stage 0 compiler 

    This avoids useless rebuilds of the demangler when modifying the compiler.
    @Zalathar
    Zalathar committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    36c3f90 View commit details
    Browse the repository at this point in the history