-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #117482
Rollup of 4 pull requests #117482
Commits on Oct 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 91405ab - Browse repository at this point
Copy the full SHA 91405abView commit details
Commits on Oct 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8076414 - Browse repository at this point
Copy the full SHA 8076414View commit details -
Configuration menu - View commit details
-
Copy full SHA for 147c4a5 - Browse repository at this point
Copy the full SHA 147c4a5View commit details
Commits on Nov 1, 2023
-
Inline and remove
create_session
.Currently the parts of session initialization that happen within `rustc_interface` are split between `run_compiler` and `create_session`. This split isn't necessary and obscures what's happening. This commit merges the two functions. I think a single longer function is much clearer than splitting this code across two functions in different modules, especially when `create_session` has 13 parameters, and is misnamed (it also creates the codegen backend). The net result is 43 fewer lines of code.
Configuration menu - View commit details
-
Copy full SHA for 587af91 - Browse repository at this point
Copy the full SHA 587af91View commit details -
Rollup merge of rust-lang#115626 - clarfonthey:unchecked-math, r=thomcc
Clean up unchecked_math, separate out unchecked_shifts Tracking issue: rust-lang#85122 Changes: 1. Remove `const_inherent_unchecked_arith` flag and make const-stability flags the same as the method feature flags. Given the number of other unsafe const fns already stabilised, it makes sense to just stabilise these in const context when they're stabilised. 2. Move `unchecked_shl` and `unchecked_shr` into a separate `unchecked_shifts` flag, since the semantics for them are unclear and they'll likely be stabilised separately as a result. 3. Add an `unchecked_neg` method exclusively to signed integers, under the `unchecked_neg` flag. This is because it's a new API and probably needs some time to marinate before it's stabilised, and while it *would* make sense to have a similar version for unsigned integers since `checked_neg` also exists for those there is absolutely no case where that would be a good idea, IMQHO. The longer-term goal here is to prepare the `unchecked_math` methods for an FCP and stabilisation since they've existed for a while, their semantics are clear, and people seem in favour of stabilising them.
Configuration menu - View commit details
-
Copy full SHA for 260e07b - Browse repository at this point
Copy the full SHA 260e07bView commit details -
Rollup merge of rust-lang#117397 - compiler-errors:dont-emit-good-pat…
…h-on-panic, r=TaKO8Ki Don't emit delayed good-path bugs on panic This should fix rust-lang#117381, cc ``@RalfJung`` As opposed to delayed bugs, delayed *good path* bugs really don't make sense to show on panics.
Configuration menu - View commit details
-
Copy full SHA for 6bbe22c - Browse repository at this point
Copy the full SHA 6bbe22cView commit details -
Rollup merge of rust-lang#117401 - chenyukang:yukang-cleanup-hir-type…
…ck-suggestions, r=compiler-errors Refactor: move suggestion functions from demand to suggestions follow-up from rust-lang#116841 (comment)
Configuration menu - View commit details
-
Copy full SHA for 6c893e6 - Browse repository at this point
Copy the full SHA 6c893e6View commit details -
Rollup merge of rust-lang#117475 - nnethercote:rm-create_session, r=o…
…li-obk Inline and remove `create_session`. Currently the parts of session initialization that happen within `rustc_interface` are split between `run_compiler` and `create_session`. This split isn't necessary and obscures what's happening. This commit merges the two functions. I think a single longer function is much clearer than splitting this code across two functions in different modules, especially when `create_session` has 13 parameters, and is misnamed (it also creates the codegen backend). The net result is 43 fewer lines of code. r? ``@oli-obk``
Configuration menu - View commit details
-
Copy full SHA for 515fdbf - Browse repository at this point
Copy the full SHA 515fdbfView commit details