Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove from vacation and compiler review group #117613

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Remove from vacation and compiler review group #117613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,19 +608,18 @@ cc = ["@nnethercote"]
[assign]
warn_non_default_branch = true
contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html"
users_on_vacation = ["jyn514", "jackh726", "WaffleLapkin", "oli-obk"]
users_on_vacation = ["jyn514", "WaffleLapkin", "oli-obk"]

[assign.adhoc_groups]
compiler-team = [
"@cjgillot",
"@compiler-errors",
"@petrochenkov",
"@davidtwco",
"@oli-obk",
"@wesleywiser",
]
compiler-team-contributors = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe these two should just be merged, i dont think its very useful to have them separate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's basically no reason to assign a review specifically to a compiler team member. The team group in the organization can be pinged if a FCP needs started.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, and agree. Just didn't do it in this PR so its "trivial".

"@compiler-errors",
"@jackh726",
"@TaKO8Ki",
"@WaffleLapkin",
"@b-naber",
Expand Down
Loading