Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for #117626 #117636

Merged
merged 1 commit into from
Jan 4, 2024
Merged

add test for #117626 #117636

merged 1 commit into from
Jan 4, 2024

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Nov 6, 2023 •
edited
Loading

Close #117626

@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2023

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Nov 6, 2023

cc @oli-obk

@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2023

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

@bors
Copy link
Contributor

bors commented Nov 16, 2023

☔ The latest upstream changes (presumably #117875) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino
Copy link
Contributor

I think there are still a few comments + a rebase pending so I'll switch to waiting on author to fix those. Please request a new review with @rustbot ready when appropriate, thanks.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023
@apiraino
Copy link
Contributor

also I can probably rotate the review assignment

r? compiler

@rustbot rustbot assigned TaKO8Ki and unassigned wesleywiser Dec 28, 2023
@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 28, 2023

#117626 appears to be work well now and I plan to add test cases.

@bvanjoi
Copy link
Contributor Author

bvanjoi commented Dec 28, 2023

I've only added the test case, and I'm curious about which PR has resolved issue #117636..

@bvanjoi bvanjoi changed the title check is violation ty included by const val add test for #117626 Dec 28, 2023
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Jan 4, 2024 •
edited
Loading

@bors r+ rollup Thanks.

@bors
Copy link
Contributor

bors commented Jan 4, 2024

📌 Commit 437f07b has been approved by TaKO8Ki

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#117636 - bvanjoi:fix-117626, r=TaKO8Ki
b05273b 
add test for rust-lang#117626

Close rust-lang#117626
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2024
@bors
Auto merge of rust-lang#119570 - matthiaskrgr:rollup-evjh62w, r=matth…
249801b 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#117636 (add test for rust-lang#117626)
 - rust-lang#118704 (Promote `riscv32{im|imafc}` targets to tier 2)
 - rust-lang#119184 (Switch from using `//~ERROR` annotations with `--error-format` to `error-pattern`)
 - rust-lang#119325 (custom mir: make it clear what the return block is)
 - rust-lang#119391 (Use Result::flatten in catch_with_exit_code)
 - rust-lang#119431 (Support reg_addr register class in s390x inline assembly)
 - rust-lang#119475 (Remove libtest's dylib)
 - rust-lang#119532 (Make offset_of field parsing use metavariable which handles any spacing)
 - rust-lang#119553 (stop feed vis when cant access for trait item)
 - rust-lang#119556 (Reland optimized-compiler-builtins config)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 4, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2024
@bors
Auto merge of rust-lang#119578 - matthiaskrgr:rollup-42yizmx, r=matth…
4c5ce1f 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#117636 (add test for rust-lang#117626)
 - rust-lang#118704 (Promote `riscv32{im|imafc}` targets to tier 2)
 - rust-lang#119184 (Switch from using `//~ERROR` annotations with `--error-format` to `error-pattern`)
 - rust-lang#119325 (custom mir: make it clear what the return block is)
 - rust-lang#119391 (Use Result::flatten in catch_with_exit_code)
 - rust-lang#119431 (Support reg_addr register class in s390x inline assembly)
 - rust-lang#119475 (Remove libtest's dylib)
 - rust-lang#119532 (Make offset_of field parsing use metavariable which handles any spacing)
 - rust-lang#119553 (stop feed vis when cant access for trait item)
 - rust-lang#119574 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5c47d77 into rust-lang:master Jan 4, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2024
@rust-timer
Unrolled build for rust-lang#117636
06a0ff7 
Rollup merge of rust-lang#117636 - bvanjoi:fix-117626, r=TaKO8Ki

add test for rust-lang#117626

Close rust-lang#117626
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@TaKO8Ki TaKO8Ki

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.

Nightly regression in Structual Eq check for match
7 participants
@bvanjoi @rustbot @bors @apiraino @TaKO8Ki @compiler-errors @wesleywiser