Reorder checks to make sure potential missing expect on Option/Result… #117695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
2 times, most recently
from
ac19d49 to
d38925c
Compare
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
d38925c to
28dca56
Compare
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
28dca56 to
ed3a427
Compare
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
ed3a427 to
348e59f
Compare
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
348e59f to
3af6809
Compare
This comment has been minimized.
This comment has been minimized.
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
3af6809 to
00001eb
Compare
This comment has been minimized.
This comment has been minimized.
Suggestions are reordered to to make sure potential missing expect on Option/Result runs before the suggestion to remove the last method call
3tilley
force-pushed
the
prioritise-unwrap-expect-over-last-method-call
branch
from
00001eb to
1854776
Compare
|
Ok after a few silly mistakes and some wasted cloud resources, this has passed. @compiler-errors or other, is there anything else I need to do? |
|
@rustbot review |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#114224 (rustc_llvm: Link to libkstat on Solaris/SPARC) - rust-lang#117695 (Reorder checks to make sure potential missing expect on Option/Result…) - rust-lang#117870 (`fn args_ref_X` to `fn args_X`) - rust-lang#117879 (tests: update check for inferred nneg on zext) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
Rollup merge of rust-lang#117695 - 3tilley:prioritise-unwrap-expect-over-last-method-call, r=compiler-errors Reorder checks to make sure potential missing expect on Option/Result… … runs before removing last method call Fixes rust-lang#117669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… runs before removing last method call
Fixes #117669