Skip to content

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Nov 10, 2023

The subcommand ffx product-bundle has been removed, and replaced with the subcommand ffx product. This changes fuchsia-test-runner.py to use it to download the SDK and product bundle for the latest release of Fuchsia.

@rustbot
Copy link
Collaborator

rustbot commented Nov 10, 2023

r? @Kobzol

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 10, 2023
@tmandry
Copy link
Member

tmandry commented Nov 10, 2023

r? @tmandry

@rustbot rustbot assigned tmandry and unassigned Kobzol Nov 10, 2023
@tmandry
Copy link
Member

tmandry commented Nov 10, 2023

@bors delegate+ rollup

r=me after nit

@bors
Copy link
Collaborator

bors commented Nov 10, 2023

✌️ @erickt, you can now approve this pull request!

If @tmandry told you to "r=me" after making some further change, please make that change, then do @bors r=@tmandry

The subcommand `ffx product-bundle` has been removed, and replaced with
the subcommand `ffx product`. This changes `fuchsia-test-runner.py` to
use it to download the SDK and product bundle for the latest release of
Fuchsia.
@erickt
Copy link
Contributor Author

erickt commented Nov 10, 2023

@bors r=@tmandry

@bors
Copy link
Collaborator

bors commented Nov 10, 2023

📌 Commit d7fd2de has been approved by tmandry

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2023
@bors
Copy link
Collaborator

bors commented Nov 11, 2023

⌛ Testing commit d7fd2de with merge 6f308b8...

@bors
Copy link
Collaborator

bors commented Nov 11, 2023

☀️ Test successful - checks-actions
Approved by: tmandry
Pushing 6f308b8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2023
@bors bors merged commit 6f308b8 into rust-lang:master Nov 11, 2023
@rustbot rustbot added this to the 1.75.0 milestone Nov 11, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6f308b8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.5%, 1.1%] 7
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.8% [-1.2%, -0.6%] 6
Improvements ✅
(secondary)
-0.7% [-0.7%, -0.7%] 1
All ❌✅ (primary) 0.0% [-1.2%, 1.1%] 13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.5%, -0.4%] 2
Improvements ✅
(secondary)
-2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) -0.4% [-0.5%, -0.4%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.48s -> 674.031s (-0.21%)
Artifact size: 311.11 MiB -> 311.12 MiB (0.00%)

@workingjubilee workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. O-fuchsia Operating system: Fuchsia S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants