target_feature: make it more clear what that 'Option' means #117834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_gcc cc @antoyo |
RalfJung
force-pushed
the
target-feature-stability
branch
from
622b6a4 to
5b50069
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 14, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116244 (Apply structured suggestion that allows test to work since 1.64) - rust-lang#117686 (Build pre-coroutine-transform coroutine body on error) - rust-lang#117834 (target_feature: make it more clear what that 'Option' means) - rust-lang#117893 (Suggest dereferencing the LHS for binops such as `&T == T`) - rust-lang#117911 (Fix some typos) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 15, 2023
Rollup merge of rust-lang#117834 - RalfJung:target-feature-stability, r=b-naber target_feature: make it more clear what that 'Option' means Reading those tables in compiler/rustc_codegen_ssa/src/target_features.rs, it's not immediately clear that `None` means "stable". Let's use an enum with appropriately named variants to make that more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading those tables in compiler/rustc_codegen_ssa/src/target_features.rs, it's not immediately clear that
Nonemeans "stable". Let's use an enum with appropriately named variants to make that more obvious.