make LayoutError::Cycle carry ErrorGuaranteed

[compiler-errors]

Addresses a FIXME, and also I think it's wise for error variants to carry their ErrorGuaranteed -- makes it easier to use that ErrorGuaranteed for creating, e.g. TyKind::Error and other error kinds. Splitting out from #117703.

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 121d9f5 with merge 619fde3...

[compiler-errors]

This is definitely not the reason for the perf regression in #117703.

[bors]

☀️ Try build successful - checks-actions
Build commit: 619fde3 (619fde37946de7fedd74964cd0c5fd1706cdc6ae)

[rust-timer]

Finished benchmarking commit (619fde3): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[0.5%, 4.8%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	2.6%	[0.5%, 4.8%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.6%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.749s -> 673.669s (-0.01%)
Artifact size: 311.08 MiB -> 311.07 MiB (-0.00%)

[cjgillot]

@bors r+ rollup

[bors]

📌 Commit 121d9f5 has been approved by cjgillot

It is now in the queue for this repository.

[bors]

⌛ Testing commit 121d9f5 with merge 8d57ad1...

[bors]

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 8d57ad1 to master...

[rust-timer]

Finished benchmarking commit (8d57ad1): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-0.6%	[-0.6%, -0.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.6%	[-0.6%, -0.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.271s -> 676.64s (0.50%)
Artifact size: 311.10 MiB -> 311.08 MiB (-0.01%)