Remove deprecated --check-cfg syntax
#117981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Some changes occurred in src/tools/rust-analyzer cc @rust-lang/rust-analyzer |
lnicola
reviewed
Nov 16, 2023
I've update the |
Yes, very much, but if it's required for this PR, we'll need a sync PR before this lands. |
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Nov 16, 2023
internal: Bump libc CC rust-lang/rust#117981
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2023
Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang#117981.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2023
Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang#117981.
Urgau
force-pushed
the
check-cfg-remove-deprecated-syntax
branch
from
c6b1230
to
f405a1c
Compare
|
☔ The latest upstream changes (presumably #118134) made this pull request unmergeable. Please resolve the merge conflicts. |
Urgau
force-pushed
the
check-cfg-remove-deprecated-syntax
branch
2 times, most recently
from
7397a4d
to
623e99e
Compare
b-naber
approved these changes
Dec 4, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
fee1-dead
added a commit
to fee1-dead-contrib/rust
that referenced
this pull request
Dec 5, 2023
…syntax, r=b-naber Remove deprecated `--check-cfg` syntax This PR removes the deprecated `--check-cfg` `names(...)` and `values(...)` syntax. Follow up to rust-lang#111072 Part of rust-lang/compiler-team#636 r? compiler
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2023
…fee1-dead Rollup of 8 pull requests Successful merges: - rust-lang#117922 (Tweak unclosed generics errors) - rust-lang#117981 (Remove deprecated `--check-cfg` syntax) - rust-lang#118471 (Fix typos in README.md) - rust-lang#118488 (Change prefetch to avoid deadlock) - rust-lang#118605 (Remove `#[rustc_host]`, use internal desugaring) - rust-lang#118608 (Use default params until effects in desugaring) - rust-lang#118614 (Update books) - rust-lang#118637 (rustc_symbol_mangling,rustc_interface,rustc_driver_impl: Enforce `rustc::potential_query_instability` lint) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
Version 0.2.150 include support for the new check-cfg syntax
Urgau
force-pushed
the
check-cfg-remove-deprecated-syntax
branch
from
623e99e
to
3f0369e
Compare
rustbot
added
T-bootstrap
Urgau
force-pushed
the
check-cfg-remove-deprecated-syntax
branch
3 times, most recently
from
81591ea
to
3f0369e
Compare
|
After some trouble finding a runner that actually test the step that broke, I can confirm that it is solved by 801bc56 (cf. temporary x86_64-gnu runner). The PR can be re-approved. @rustbot labels -T-bootstrap -T-infra -A-testsuite -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
@bors r=b-naber |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 6, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#117981 (Remove deprecated `--check-cfg` syntax) - rust-lang#118177 (Suppress warnings in LLVM wrapper when targeting MSVC) - rust-lang#118317 (tip for define macro name after `macro_rules!`) - rust-lang#118504 (Enforce `must_use` on associated types and RPITITs that have a must-use trait in bounds) - rust-lang#118660 (rustc_arena: add `alloc_str`) - rust-lang#118681 (Fix is_foreign_item for StableMIR instance ) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 7, 2023
Rollup merge of rust-lang#117981 - Urgau:check-cfg-remove-deprecated-syntax, r=b-naber Remove deprecated `--check-cfg` syntax This PR removes the deprecated `--check-cfg` `names(...)` and `values(...)` syntax. Follow up to rust-lang#111072 Part of rust-lang/compiler-team#636 r? compiler
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang/rust#117981.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
Subtree update of `rust-analyzer` r? `@ghost` Out of band, but required for rust-lang/rust#117981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
--check-cfgnames(...)andvalues(...)syntax.Follow up to #111072
Part of rust-lang/compiler-team#636
r? compiler