Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate there are no critical call edges in optimized MIR #118075

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Validate there are no critical call edges in optimized MIR #118075

merged 3 commits into from
Nov 25, 2023

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Nov 19, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@bjorn3
Copy link
Member

bjorn3 commented Nov 19, 2023

There is a typo in the last commit message: corotuine -> coroutine

@tmiasko tmiasko force-pushed the validate-critical-call-edges branch from ce43202 to 2e7ff34 Compare November 19, 2023 22:04
@tmiasko tmiasko changed the title Validate that critical call edges are split in optimized MIR Validate there are no critical call edges in optimized MIR Nov 19, 2023
@tmiasko tmiasko force-pushed the validate-critical-call-edges branch from 2e7ff34 to ddff65e Compare November 21, 2023 17:54
cjgillot
cjgillot reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@cjgillot cjgillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me with a nit.

compiler/rustc_const_eval/src/transform/validate.rs Outdated Show resolved Hide resolved
@tmiasko tmiasko force-pushed the validate-critical-call-edges branch from ddff65e to 329d015 Compare November 22, 2023 00:59
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 25, 2023

📌 Commit 329d015 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
@bors
Copy link
Contributor

bors commented Nov 25, 2023

⌛ Testing commit 329d015 with merge 4fffe65...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2023
@bors
Auto merge of rust-lang#118075 - tmiasko:validate-critical-call-edges…
4fffe65 
…, r=cjgillot

Validate there are no critical call edges in optimized MIR
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Nov 25, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 25, 2023
@tmiasko
Copy link
Contributor Author

tmiasko commented Nov 25, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2023
@bors
Copy link
Contributor

bors commented Nov 25, 2023

⌛ Testing commit 329d015 with merge fad6bb8...

@bors
Copy link
Contributor

bors commented Nov 25, 2023

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing fad6bb8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 25, 2023
@bors bors merged commit fad6bb8 into rust-lang:master Nov 25, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (fad6bb8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.9% [0.7%, 1.2%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.2% [-3.2%, -0.9%] 4
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.85s -> 674.747s (-0.02%)
Artifact size: 313.30 MiB -> 313.31 MiB (0.00%)

@tmiasko tmiasko deleted the validate-critical-call-edges branch November 26, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

Assignees

@cjgillot cjgillot

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tmiasko @rustbot @bjorn3 @cjgillot @bors @rust-log-analyzer @rust-timer