-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable SIMD subtree update #118077
Portable SIMD subtree update #118077
Conversation
Add scalar shifts
…3-11-19, r=workingjubilee Portable SIMD subtree update Syncs nightly to the latest changes from rust-lang/portable-simd r? `@rust-lang/libs`
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
That's silly, I thought |
@bors r+ |
@calebzulawski Docs are primarily for the user, their ability to be hosted on docs.rs or other docs sites is secondary: that's a choice a user gets to make. Which means docs are built, primarily, for informing you about what's available for the specific build configuration you did. Every crate has to configure docs.rs metadata to get something hostable if there's no defaults. |
☀️ Test successful - checks-actions |
whew |
Finished benchmarking commit (3f1e30a): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 670.8s -> 672.666s (0.28%) |
Strange regression, but mostly on doc builds. Could be std/core metadata changes. |
Yeah, idk. I wouldn't expect these changes to affect performance. Maybe there are more trait implementations? I can't think of anything significant |
yeah, if we add a function then there's more docs to generate, them's the breaks. |
Seems reasonable to me @rustbot label: +perf-regression-triaged |
Syncs nightly to the latest changes from rust-lang/portable-simd
r? @rust-lang/libs