Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable SIMD subtree update #118077

Merged
merged 78 commits into from
Dec 2, 2023

Conversation

calebzulawski
Copy link
Member

Syncs nightly to the latest changes from rust-lang/portable-simd

r? @rust-lang/libs

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 2, 2023
@bors
Copy link
Contributor

bors commented Dec 2, 2023

⌛ Testing commit 4d96078 with merge 54b4148...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2023
…3-11-19, r=workingjubilee

Portable SIMD subtree update

Syncs nightly to the latest changes from rust-lang/portable-simd

r? `@rust-lang/libs`
@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Dec 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 2, 2023
@calebzulawski
Copy link
Member Author

That's silly, I thought core::arch::x86_64 always existed when building docs. Anyway, I removed the link. @workingjubilee hope this works 🙃

@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 2, 2023

📌 Commit bcb1c41 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023
@workingjubilee
Copy link
Member

@calebzulawski Docs are primarily for the user, their ability to be hosted on docs.rs or other docs sites is secondary: that's a choice a user gets to make. Which means docs are built, primarily, for informing you about what's available for the specific build configuration you did. Every crate has to configure docs.rs metadata to get something hostable if there's no defaults.

@bors
Copy link
Contributor

bors commented Dec 2, 2023

⌛ Testing commit bcb1c41 with merge 3f1e30a...

@bors
Copy link
Contributor

bors commented Dec 2, 2023

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 3f1e30a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2023
@bors bors merged commit 3f1e30a into rust-lang:master Dec 2, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 2, 2023
@calebzulawski
Copy link
Member Author

whew

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3f1e30a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.3%, 2.1%] 14
Regressions ❌
(secondary)
1.3% [0.2%, 2.2%] 23
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.7% [0.3%, 2.1%] 14

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.9% [1.0%, 2.7%] 4
Regressions ❌
(secondary)
1.9% [0.9%, 3.3%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [1.0%, 2.7%] 4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [1.5%, 2.5%] 2
Regressions ❌
(secondary)
2.3% [0.7%, 4.4%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.0% [1.5%, 2.5%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.8s -> 672.666s (0.28%)
Artifact size: 313.92 MiB -> 313.96 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Dec 2, 2023
@lqd
Copy link
Member

lqd commented Dec 2, 2023

Strange regression, but mostly on doc builds. Could be std/core metadata changes.

@calebzulawski
Copy link
Member Author

Yeah, idk. I wouldn't expect these changes to affect performance. Maybe there are more trait implementations? I can't think of anything significant

@workingjubilee
Copy link
Member

yeah, if we add a function then there's more docs to generate, them's the breaks.

@rylev
Copy link
Member

rylev commented Dec 5, 2023

yeah, if we add a function then there's more docs to generate, them's the breaks.

Seems reasonable to me

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Dec 5, 2023
@workingjubilee workingjubilee added A-SIMD Area: SIMD (Single Instruction Multiple Data) PG-portable-simd Project group: Portable SIMD (https://github.com/rust-lang/project-portable-simd) labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. PG-portable-simd Project group: Portable SIMD (https://github.com/rust-lang/project-portable-simd) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.