Skip to content

Queries cleanups #118086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2023
Merged

Queries cleanups #118086

merged 4 commits into from
Nov 22, 2023

Conversation

nnethercote
Copy link
Contributor

r? @bjorn3

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 20, 2023
@nnethercote
Copy link
Contributor Author

I'm not 100% on whether the last two are a good idea, see what you think.

@bjorn3
Copy link
Member

bjorn3 commented Nov 20, 2023

The first commit conflicts with #117584

bjorn3
bjorn3 reviewed Nov 20, 2023
View reviewed changes
bjorn3
bjorn3 reviewed Nov 20, 2023
View reviewed changes
bjorn3
bjorn3 reviewed Nov 20, 2023
View reviewed changes
@nnethercote
Copy link
Contributor Author

I have removed the first commit, and addressed the comments about the remaining commits.

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

☔ The latest upstream changes (presumably #118143) made this pull request unmergeable. Please resolve the merge conflicts.

@nnethercote
Add comments about a timer.
cf56190
@nnethercote
Add two useful comments.
09c807e
@nnethercote
Make Compiler::{sess,codegen_backend} public.
3a4798c 
And remove the relevant getters on `Compiler` and `Queries`.
@nnethercote
Merge Queries::{ongoing_codegen,linker}.
971010e 
There is no real need for them to be separate.
@nnethercote
Copy link
Contributor Author

I rebased to fix the conflicts.

@bjorn3
Copy link
Member

bjorn3 commented Nov 22, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

📌 Commit 971010e has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2023
@bors
Copy link
Collaborator

bors commented Nov 22, 2023

⌛ Testing commit 971010e with merge a6b8ae5...

@bors
Copy link
Collaborator

bors commented Nov 22, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing a6b8ae5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2023
@bors bors merged commit a6b8ae5 into rust-lang:master Nov 22, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 22, 2023
This was referenced Nov 22, 2023
Merged
Merged
@nnethercote nnethercote deleted the queries-cleanups branch November 22, 2023 20:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a6b8ae5): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 676.065s -> 676.864s (0.12%)
Artifact size: 313.79 MiB -> 313.80 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @bjorn3 @bors @rust-timer @rustbot