-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add is_xxx_or
for Result
and Option
#118090
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thank you for the PR! This PR contains a public library API change, which should follow the proper process of creating an ACP first: https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html |
r? libs-api |
@Embers-of-the-Fire any updates on creating the ACP for this? |
Sorry I've been busy lately and haven't been following the action here. I guess there is a need for a standard RFC process for such small changes? I will prepare it now if needed. Edit: ACP: ACP |
@rustbot review |
These supplements are akin to the current
is_xxx_and
APIs.[must_use]
We generally utilize these methods to verify an option or result, thus necessitating the use of
must_use
.ACP
ACP is likely to be a trivial task, given that this modification is likely smaller than the accompanying documentation.