Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add is_xxx_or for Result and Option #118090

Closed

Conversation

Embers-of-the-Fire
Copy link

These supplements are akin to the current is_xxx_and APIs.

[must_use]

We generally utilize these methods to verify an option or result, thus necessitating the use of must_use.

ACP

ACP is likely to be a trivial task, given that this modification is likely smaller than the accompanying documentation.

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2023
@Noratrieb
Copy link
Member

Noratrieb commented Jan 21, 2024

Thank you for the PR! This PR contains a public library API change, which should follow the proper process of creating an ACP first: https://std-dev-guide.rust-lang.org/development/feature-lifecycle.html
Use @rustbot ready when your ACP has been accepeted.

@Noratrieb Noratrieb added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2024
@joshtriplett
Copy link
Member

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Feb 11, 2024
@rustbot rustbot assigned BurntSushi and unassigned joshtriplett Feb 11, 2024
@Dylan-DPC Dylan-DPC added the needs-acp This change is blocked on the author creating an ACP. label Feb 17, 2024
@Dylan-DPC
Copy link
Member

@Embers-of-the-Fire any updates on creating the ACP for this?

@Embers-of-the-Fire
Copy link
Author

Embers-of-the-Fire commented Feb 25, 2024

@Embers-of-the-Fire any updates on creating the ACP for this?

Sorry I've been busy lately and haven't been following the action here. I guess there is a need for a standard RFC process for such small changes? I will prepare it now if needed.

Edit: ACP: ACP

@Embers-of-the-Fire
Copy link
Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-acp This change is blocked on the author creating an ACP. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants