improve tool-only help for multiple #[default] variants
#118131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lukas-code
force-pushed
the
multi-default
branch
from
63af53b to
f697a00
Compare
|
What's a tool-only suggestion?^^ |
It's a suggestion that doesn't show up on the CLI, but you can auto-apply it with rust-analyzer (and JetBrains IDE probably (?)). In this case we get a bunch of "make |
wesleywiser
approved these changes
Nov 22, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2023
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#118131 (improve tool-only help for multiple `#[default]` variants) - rust-lang#118146 (Rework supertrait lint once again) - rust-lang#118167 (make the 'abi_unadjusted' feature internal) - rust-lang#118169 (print query map for deadlock when using parallel front end) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 23, 2023
Rollup merge of rust-lang#118131 - lukas-code:multi-default, r=wesleywiser improve tool-only help for multiple `#[default]` variants When defining an enum with multiple `#[default]` variants, we emit a tool-only suggestion for every `#[default]`ed variant to remove all other `#[default]`s. This PR improves the suggestion to correctly handle the cases where one variant has multiple `#[default]`s and where different `#[default]`s have the same span due to macro expansions. fixes rust-lang#118119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining an enum with multiple
#[default]variants, we emit a tool-only suggestion for every#[default]ed variant to remove all other#[default]s. This PR improves the suggestion to correctly handle the cases where one variant has multiple#[default]s and where different#[default]s have the same span due to macro expansions.fixes #118119