Making User<T> and User<[T]> Send
#118241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
O-SGX
|
@mzohreva Could you review as well? |
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 24, 2023
raoulstrackx
force-pushed
the
raoul/gh-530-make_userspace_types_send
branch
from
e46248a
to
4a8ba05
Compare
arai-fortanix
approved these changes
Nov 27, 2023
mzohreva
approved these changes
Nov 27, 2023
|
@joshtriplett could you do a final review? Thank you! |
|
@bors r=Nilstrieb,dtolnay |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 9, 2024
…e_userspace_types_send, r=Nilstrieb,dtolnay Making `User<T>` and `User<[T]>` `Send` All `User` types in SGX point to owned memory in userspace. Special care is always needed when accessing this memory as it must be assumed that an attacker is always able to change its content. Therefore, we can also easily transfer this memory between thread boundaries. cc: `@mzohreva` `@vn971` `@belalH` `@jethrogb`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#117372 (Update stdarch submodule) - rust-lang#118241 (Making `User<T>` and `User<[T]>` `Send`) - rust-lang#118748 (std: getrandom simplification for freebsd.) - rust-lang#119527 (don't reexport atomic::ordering via rustc_data_structures, use std import) - rust-lang#119699 (Merge dead bb pruning and unreachable bb deduplication.) - rust-lang#119723 (Remove `-Zdont-buffer-diagnostics`.) - rust-lang#119756 (rustdoc-search: reuse individual types in function signatures) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#118241 (Making `User<T>` and `User<[T]>` `Send`) - rust-lang#118645 (chore: Bump compiler_builtins) - rust-lang#118680 (Add support for shell argfiles) - rust-lang#119721 (`~const` trait and projection bounds do not imply their non-const counterparts) - rust-lang#119768 (core: panic: fix broken link) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2024
Rollup merge of rust-lang#118241 - fortanix:raoul/rust-langgh-530-make_userspace_types_send, r=Nilstrieb,dtolnay Making `User<T>` and `User<[T]>` `Send` All `User` types in SGX point to owned memory in userspace. Special care is always needed when accessing this memory as it must be assumed that an attacker is always able to change its content. Therefore, we can also easily transfer this memory between thread boundaries. cc: ``@mzohreva`` ``@vn971`` ``@belalH`` ``@jethrogb``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
Usertypes in SGX point to owned memory in userspace. Special care is always needed when accessing this memory as it must be assumed that an attacker is always able to change its content. Therefore, we can also easily transfer this memory between thread boundaries.cc: @mzohreva @vn971 @BelalH @jethrogb