Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from users on vacation #118318

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin commented Nov 26, 2023

I think I have some capacity for reviews now and recently there were a few PRs with explicit r? @WaffleLapkin which I'm actually capable to review, so

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2023
@WaffleLapkin
Copy link
Member Author

Oh no, the assignment was accidental 😅

But yeah, anyway @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 26, 2023

📌 Commit 4a22b1a has been approved by WaffleLapkin

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#118296 (rustdoc: replace `elemIsInParent` with `Node.contains`)
 - rust-lang#118302 (Clean dead codes)
 - rust-lang#118311 (merge `DefKind::Coroutine` into `Defkind::Closure`)
 - rust-lang#118318 (Remove myself from users on vacation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cb04603 into rust-lang:master Nov 26, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 26, 2023
Rollup merge of rust-lang#118318 - WaffleLapkin:unvacation-waffle, r=WaffleLapkin

Remove myself from users on vacation

I think I have some capacity for reviews now and recently there were a few PRs with explicit `r? `@WaffleLapkin`` which I'm actually capable to review, so
@rustbot rustbot added this to the 1.76.0 milestone Nov 26, 2023
@WaffleLapkin WaffleLapkin deleted the unvacation-waffle branch November 27, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants