Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_session cleanups #118472

Merged
merged 13 commits into from
Dec 1, 2023
Merged

rustc_session cleanups #118472

merged 13 commits into from
Dec 1, 2023

Conversation

nnethercote
Copy link
Contributor

r? @bjorn3

@nnethercote
Remove unused features.
866aa2d
@nnethercote
Reorder some use items.
3521abd
@nnethercote
Move MetadataLoader{,Dyn} to rustc_metadata.
99ac405 
They're not used in `rustc_session`, and `rustc_metadata` is a more
obvious location.

`MetadataLoader` was originally put into `rustc_session` in rust-lang#41565 to
avoid a dependency on LLVM, but things have changed a lot since then and
that's no longer relevant, e.g. `rustc_codegen_llvm` depends on
`rustc_metadata`.
@nnethercote
Remove unused FileMatch.
c5408b6
@nnethercote
Update a comment.
f8ce186 
Save analysis was removed a while ago.
@nnethercote
Move is_ascii_ident to where it's used.
dba9416
@nnethercote
Improve integer interning in default_configuration.
24d4fe4 
We have `sym::integer` for interning integers. Using it lets us use
symbols directy, and not have to explicitly go through strings.
@nnethercote
Sort PRINT_KINDS.
20046ce 
Alphabetical order is nicer than random order.
@nnethercote
Inline and remove select_debuginfo_compression.
b6d0493 
It's trivial and has a single callsite.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 30, 2023
@nnethercote
Copy link
Contributor Author

I updated to address the comments. Thank you for the fast review :)

@bjorn3
Copy link
Member

bjorn3 commented Nov 30, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2023

📌 Commit 275b793 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2023
@bors
Copy link
Contributor

bors commented Dec 1, 2023

⌛ Testing commit 275b793 with merge 1d726a2...

@bors
Copy link
Contributor

bors commented Dec 1, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 1d726a2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2023
@bors bors merged commit 1d726a2 into rust-lang:master Dec 1, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d726a2): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)		 1.9% [1.5%, 2.3%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.191s -> 673.779s (-0.06%)
Artifact size: 313.41 MiB -> 313.43 MiB (0.01%)

@nnethercote nnethercote deleted the rustc_session branch December 1, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@bjorn3 bjorn3

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nnethercote @bjorn3 @bors @rust-timer @rustbot