Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct the arg for 'suggest to use associated function syntax' diagnostic #118502

Merged
merged 1 commit into from
Dec 9, 2023
Merged

fix: correct the arg for 'suggest to use associated function syntax' diagnostic #118502

merged 1 commit into from
Dec 9, 2023

Conversation

Young-Flash
Copy link
Member

close #118469

@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 1, 2023
@Young-Flash
Copy link
Member Author

seems b-naber has not time to review this, let's try @rustbot r?

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2023

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2023

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@Young-Flash
Copy link
Member Author

could @saethlin help review this?

@saethlin
Copy link
Member

saethlin commented Dec 6, 2023

Did you pick me because you saw my name on the issue? I really don't know much of anything about this part of the compiler, so I wouldn't have picked me.

@Young-Flash
Copy link
Member Author

Did you pick me because you saw my name on the issue?

Oh yeah.

I really don't know much of anything about this part of the compiler, so I wouldn't have picked me.

Sorry for the interruption.

@saethlin
Copy link
Member

saethlin commented Dec 7, 2023

No need to apologize. A lot of the compiler team tends to go on vacation around this time, and some of the contributors group (which I'm in) does get review requests.

r? compiler

@rustbot rustbot assigned compiler-errors and unassigned b-naber Dec 7, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 8, 2023

📌 Commit e4cfe03 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 8, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
@bors
Auto merge of rust-lang#118763 - matthiaskrgr:rollup-mgyf5hp, r=matth…
dc3a353 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#117586 (Uplift the (new solver) canonicalizer into `rustc_next_trait_solver`)
 - rust-lang#118502 (fix: correct the arg for 'suggest to use associated function syntax' diagnostic)
 - rust-lang#118694 (Add instance evaluation and methods to read an allocation in StableMIR)
 - rust-lang#118715 (privacy: visit trait def id of projections)
 - rust-lang#118730 (recurse into refs when comparing tys for diagnostics)
 - rust-lang#118736 (temporarily revert "ice on ambguity in mir typeck")

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9041d1c into rust-lang:master Dec 9, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 9, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2023
@rust-timer
Unrolled build for rust-lang#118502
f4753fe 
Rollup merge of rust-lang#118502 - Young-Flash:fix, r=compiler-errors

fix: correct the arg for 'suggest to use associated function syntax' diagnostic

close rust-lang#118469
@Young-Flash Young-Flash deleted the fix branch December 9, 2023 09:46
@Young-Flash Young-Flash mentioned this pull request Dec 9, 2023
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 9, 2023
@GuillaumeGomez
Rollup merge of rust-lang#118775 - Young-Flash:fix, r=compiler-errors
034d73d 
chore: add test case for type with generic

follow up rust-lang#118502
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 10, 2023
@rust-timer
Unrolled build for rust-lang#118775
12cb236 
Rollup merge of rust-lang#118775 - Young-Flash:fix, r=compiler-errors

chore: add test case for type with generic

follow up rust-lang#118502
@Young-Flash Young-Flash mentioned this pull request Dec 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 29, 2023
@bors
Auto merge of rust-lang#118911 - Young-Flash:fix_issue_118819, r=fmease
3cdd004 
fix: correct the args for `disambiguate the associated function` diagnostic

This is somehow silimar to rust-lang#118502, we shouldn't take receiver as first arg all the cases.

close rust-lang#118819
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 31, 2023
@bors
Auto merge of #118911 - Young-Flash:fix_issue_118819, r=fmease
b05723b 
fix: correct the args for `disambiguate the associated function` diagnostic

This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases.

close rust-lang/rust#118819
This was referenced Jan 9, 2024
Closed
Merged
Nadrieril added a commit to Nadrieril/rust that referenced this pull request Jan 27, 2024
@Nadrieril
Rollup merge of rust-lang#119957 - Young-Flash:fix, r=fmease
5803376 
fix: correct suggestion arg for impl trait

follow up rust-lang#118502, close rust-lang#119775
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 27, 2024
@matthiaskrgr
Rollup merge of rust-lang#119957 - Young-Flash:fix, r=fmease
c6f0a5c 
fix: correct suggestion arg for impl trait

follow up rust-lang#118502, close rust-lang#119775
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2024
@rust-timer
Unrolled build for rust-lang#119957
8e89341 
Rollup merge of rust-lang#119957 - Young-Flash:fix, r=fmease

fix: correct suggestion arg for impl trait

follow up rust-lang#118502, close rust-lang#119775
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@bors
Auto merge of #118911 - Young-Flash:fix_issue_118819, r=fmease
5997651 
fix: correct the args for `disambiguate the associated function` diagnostic

This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases.

close rust-lang/rust#118819
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #118911 - Young-Flash:fix_issue_118819, r=fmease
edeb5f2 
fix: correct the args for `disambiguate the associated function` diagnostic

This is somehow silimar to rust-lang/rust#118502, we shouldn't take receiver as first arg all the cases.

close rust-lang/rust#118819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

suggest to use associated function syntax diagnostic take receiver as first arg mistakely
6 participants
@Young-Flash @rustbot @saethlin @compiler-errors @bors @b-naber