Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #118651

Closed
wants to merge 22 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
2faaea9
Provide context when `?` can't be called because of `Result<_, E>`
estebank Oct 6, 2023
276b74d
Point at fewer methods in the chain, only those that change the E type
estebank Oct 7, 2023
e688742
Detect incorrect `;` in `Option::ok_or_else` and `Result::map_err`
estebank Oct 7, 2023
cc49398
Reduce verbosity of error
estebank Oct 7, 2023
d92c2b5
add comments
estebank Oct 7, 2023
cce82d8
let-chain fmt
estebank Nov 16, 2023
d1583eb
lib features ending in '_internals?' are internal
RalfJung Nov 21, 2023
74834a9
also make 'core_intrinsics' internal
RalfJung Nov 22, 2023
d627e2a
Fix parser ICE when recovering `dyn`/`impl` after `for<...>`
sjwang05 Dec 4, 2023
65212a0
Remove `#[rustc_host]`, use internal desugaring
fee1-dead Dec 4, 2023
a0ba895
bootstrap(builder.rs): Don't explicitly warn against `semicolon_in_ex…
Xanewok Dec 5, 2023
334577f
Add deeply_normalize_for_diagnostics, use it in coherence
compiler-errors Nov 27, 2023
3448284
Continue folding if deep normalizer fails
compiler-errors Nov 28, 2023
b97ff8e
Add print_trait_sugared
compiler-errors Nov 24, 2023
f6c30b3
Add more
compiler-errors Nov 24, 2023
94fd369
Rollup merge of #116496 - estebank:question-method-chain-context, r=c…
matthiaskrgr Dec 5, 2023
13d386e
Rollup merge of #118123 - RalfJung:internal-lib-features, r=compiler-…
matthiaskrgr Dec 5, 2023
18b7570
Rollup merge of #118268 - compiler-errors:pretty-print, r=estebank
matthiaskrgr Dec 5, 2023
1503a53
Rollup merge of #118346 - compiler-errors:deeply-normalize-for-diagno…
matthiaskrgr Dec 5, 2023
ee37f4a
Rollup merge of #118585 - sjwang05:issue-118564, r=compiler-errors
matthiaskrgr Dec 5, 2023
848dc33
Rollup merge of #118605 - fee1-dead-contrib:rm-rustc_host, r=compiler…
matthiaskrgr Dec 5, 2023
ed076f8
Rollup merge of #118642 - Xanewok:patch-1, r=clubby789
matthiaskrgr Dec 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bootstrap(builder.rs): Don't explicitly warn against `semicolon_in_ex…
…pressions_from_macros`

This already wasn't passed in bootstrap.py and the lint itself already warns-by-default for 2 years now and has already been added to the future-incompat group in Rust 1.68.

See #79813 for the tracking issue.
Xanewok authored Dec 5, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a0ba895f2d6bf94da9a083eb4afce7bf6fb730a4
1 change: 0 additions & 1 deletion src/bootstrap/src/core/builder.rs
Original file line number Diff line number Diff line change
@@ -1872,7 +1872,6 @@ impl<'a> Builder<'a> {
// some code doesn't go through this `rustc` wrapper.
lint_flags.push("-Wrust_2018_idioms");
lint_flags.push("-Wunused_lifetimes");
lint_flags.push("-Wsemicolon_in_expressions_from_macros");

if self.config.deny_warnings {
lint_flags.push("-Dwarnings");