Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check principal trait ref for object safety #118686

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Only check principal trait ref for object safety #118686

merged 1 commit into from
Dec 8, 2023

Conversation

compiler-errors
Copy link
Member

It should make things a bit faster, in case we end up registering a bunch of object safety preds.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2023
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 6, 2023
@bors
Copy link
Contributor

bors commented Dec 6, 2023

⌛ Trying commit 5d3a294 with merge 6845c0d...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2023
@bors
Auto merge of rust-lang#118686 - compiler-errors:object-safety, r=<try>
6845c0d 
Only check principal trait ref for object safety

It should make things a bit faster, in case we end up registering a bunch of object safety preds.

r? `@ghost`
@bors
Copy link
Contributor

bors commented Dec 6, 2023

☀️ Try build successful - checks-actions
Build commit: 6845c0d (6845c0df8825df54819660a09d2b2794f43fdc3d)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6845c0d): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.7% [3.7%, 3.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.588s -> 675.236s (-0.35%)
Artifact size: 314.19 MiB -> 314.20 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 7, 2023
@compiler-errors
Copy link
Member Author

Not a perf difference but I still think it simplifies stuff

r? lcnr

close if you disagree

@lcnr
Copy link
Contributor

lcnr commented Dec 7, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 7, 2023

📌 Commit 5d3a294 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 7, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#118686 - compiler-errors:object-safety, r=lcnr
309487a 
Only check principal trait ref for object safety

It should make things a bit faster, in case we end up registering a bunch of object safety preds.

r? `@ghost`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Dec 7, 2023
@compiler-errors
Rollup merge of rust-lang#118686 - compiler-errors:object-safety, r=lcnr
371b00a 
Only check principal trait ref for object safety

It should make things a bit faster, in case we end up registering a bunch of object safety preds.

r? ``@ghost``
@compiler-errors compiler-errors mentioned this pull request Dec 7, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 7, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2023
@bors
Auto merge of rust-lang#118723 - matthiaskrgr:rollup-409e9u1, r=matth…
370c911 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#116420 (discard invalid spans in external blocks)
 - rust-lang#118686 (Only check principal trait ref for object safety)
 - rust-lang#118688 (Add method to get type of an Rvalue in StableMIR)
 - rust-lang#118707 (Ping GuillaumeGomez for changes in rustc_codegen_gcc)
 - rust-lang#118712 (targets: remove not-added {i386,i486}-unknown-linux-gnu)
 - rust-lang#118719 (CFI: Add char to CFI integer normalization)

Failed merges:

 - rust-lang#117586 (Uplift the (new solver) canonicalizer into `rustc_next_trait_solver`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b204303 into rust-lang:master Dec 8, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 8, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2023
@rust-timer
Unrolled build for rust-lang#118686
07f9736 
Rollup merge of rust-lang#118686 - compiler-errors:object-safety, r=lcnr

Only check principal trait ref for object safety

It should make things a bit faster, in case we end up registering a bunch of object safety preds.

r? ```@ghost```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rust-timer @bors @lcnr @rustbot