fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use #118709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cjgillot (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
oksbsb
force-pushed
the
fix-job-server
branch
from
ffe0caa
to
56574c4
Compare
This comment has been minimized.
This comment has been minimized.
oksbsb
force-pushed
the
fix-job-server
branch
from
56574c4
to
cf1cecc
Compare
|
It's not necessary to create new PRs on conflicts, rebasing and force pushing is enough. |
This comment has been minimized.
This comment has been minimized.
|
@bors retry |
|
@oksbsb: 🔑 Insufficient privileges: not in try users |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 7, 2023
fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use override rust-lang#118589, resolve merge conflict `@petrochenkov` `@SparrowLii` Thanks!
|
Possibly the reason for failure in #118716 (comment) ? If not, sorry, my pattern matching is poor in this part of the compiler. @bors r- |
bors
added
S-waiting-on-author
2. jobserver::initialize_checked should call before build_session, still should use EarlyErrorHandler, so revert stderr change in rust-lang#118635
oksbsb
force-pushed
the
fix-job-server
branch
from
cf1cecc
to
dabedb7
Compare
resloved, caused by #118635, it change stderr output. |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 8, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118505 (Elaborate on ip_addr bit conversion endianness) - rust-lang#118581 (OnceLock: Add note about drop and statics) - rust-lang#118677 ([rustdoc] Fix display of features) - rust-lang#118690 (coverage: Avoid unnecessary macros in unit tests) - rust-lang#118693 (Tell MirUsedCollector that the pointer alignment checks calls its panic symbol) - rust-lang#118695 (coverage: Merge refined spans in a separate final pass) - rust-lang#118709 (fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use) - rust-lang#118722 (rustdoc: remove unused parameter `reversed` from onEach(Lazy)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 8, 2023
Rollup merge of rust-lang#118709 - oksbsb:fix-job-server, r=SparrowLii fix jobserver GLOBAL_CLIENT_CHECKED uninitialized before use override rust-lang#118589, resolve merge conflict `@petrochenkov` `@SparrowLii` Thanks!
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override #118589, resolve merge conflict
@petrochenkov @SparrowLii
Thanks!