Fix BinOp ty() assertion and fn_sig() for closures
#118846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a few more util methods to TyKind to check for specific types.
rustbot
added
S-waiting-on-review
|
This PR changes Stable MIR cc @oli-obk, @celinval, @spastorino, @ouz-a |
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Some questions.
just wanted to confirm that today no BinaryOperation accept SIMD types. Is that correct?
I don't think we lower SIMD intrinsics to MIR binops like we do for primitives, I can see it's not happening in compiler/rustc_mir_transform/src/lower_intrinsics.rs.
rustbot
added
S-waiting-on-author
|
@compiler-errors let me know if there's anything else you would like me to change. |
|
@bors r=@compiler-errors rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 12, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118445 (Let `reuse` look inside git submodules) - rust-lang#118756 (use bold magenta instead of bold white for highlighting) - rust-lang#118797 (End locals' live range before suspending coroutine) - rust-lang#118840 (remove some redundant clones) - rust-lang#118844 (Monomorphize args while building Instance body in StableMIR) - rust-lang#118846 (Fix BinOp `ty()` assertion and `fn_sig()` for closures) - rust-lang#118848 (Add myself back to review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 12, 2023
Rollup merge of rust-lang#118846 - celinval:smir-ty-methods, r=compiler-errors Fix BinOp `ty()` assertion and `fn_sig()` for closures `BinOp::ty()` was asserting that the argument types were primitives. However, the primitive check doesn't include pointers, which can be used in a `BinaryOperation`. Thus extend the arguments to include them. Since I had to add methods to check for pointers in TyKind, I just went ahead and added a bunch more utility checks that can be handy for our users and fixed the `fn_sig()` method to also include closures. `@compiler-errors` just wanted to confirm that today no `BinaryOperation` accept SIMD types. Is that correct? r? `@compiler-errors`
celinval
added a commit
to model-checking/kani
that referenced
this pull request
Dec 13, 2023
This migration was fairly straight forward, most constructs have a 1:1 map from internal APIs to StableMIR APIs. I've also removed the `is_coroutine()` and the `is_box()` methods from `ty_stable`, since they were added to the StableMIR APIs together with other type methods here: rust-lang/rust#118846.
Correct, SIMD operations have their own path because they tend to be expressed as "don't think too hard about what's happening here in the MIR, this is just going to be lowered by the CG backend". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinOp::ty()was asserting that the argument types were primitives. However, the primitive check doesn't include pointers, which can be used in aBinaryOperation. Thus extend the arguments to include them.Since I had to add methods to check for pointers in TyKind, I just went ahead and added a bunch more utility checks that can be handy for our users and fixed the
fn_sig()method to also include closures.@compiler-errors just wanted to confirm that today no
BinaryOperationaccept SIMD types. Is that correct?r? @compiler-errors