Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[std] Add xcoff in object's feature list #118851

Merged
merged 2 commits into from
Dec 16, 2023
Merged

[std] Add xcoff in object's feature list #118851

merged 2 commits into from
Dec 16, 2023

Conversation

bzEq
Copy link
Contributor

@bzEq bzEq commented Dec 12, 2023

object-0.32.0 has supported XCOFF format. And backtrace in submodule has been updated to support XCOFF and AIX. Add xcoff to supported feature list to make backtrace built on AIX.

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 12, 2023
@bjorn3
Copy link
Member

bjorn3 commented Dec 12, 2023

Maybe we could only enable the features required for the target using per-target dependencies?

@bzEq
Copy link
Contributor Author

bzEq commented Dec 13, 2023

@rustbot ready

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2023

📌 Commit 9f64023 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
…kingjubilee

Rollup of 6 pull requests

Successful merges:

 - rust-lang#118523 (Add ASCII whitespace trimming functions to `&str`)
 - rust-lang#118851 ([std] Add xcoff in object's feature list)
 - rust-lang#118989 (Simplify lint decorator derive too)
 - rust-lang#118993 (use `if cfg!` instead of `#[cfg]`)
 - rust-lang#119003 (NFC: do not clone types that are copy)
 - rust-lang#119004 (NFC don't convert types to identical types)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6c2f00f into rust-lang:master Dec 16, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 16, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
Rollup merge of rust-lang#118851 - bzEq:std-xcoff, r=Mark-Simulacrum

[std] Add xcoff in object's feature list

object-0.32.0 has supported XCOFF format. And backtrace in submodule has been updated to support XCOFF and AIX. Add `xcoff` to supported feature list to make backtrace built on AIX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants