Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc. #118960

Merged
merged 16 commits into from
Feb 5, 2024
Merged

Add LocalWaker and ContextBuilder types to core, and LocalWake trait to alloc. #118960

merged 16 commits into from
Feb 5, 2024

Commits on Jan 20, 2024

  1. feat: add LocalWaker type, ContextBuilder type, and LocalWake trait.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    60a0819 View commit details
    Browse the repository at this point in the history

  2. perf: move null check from local_wake() to build()

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0cb5e2f View commit details
    Browse the repository at this point in the history

  3. refactor: remove in favor of and to make the API infallible.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    232cc2b View commit details
    Browse the repository at this point in the history

  4. feat: add try_waker and From<&mut Context> for ContextBuilder to allo… 

    …w the extention of contexts by futures
    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    403718b View commit details
    Browse the repository at this point in the history

  5. fix: make LocalWake available in targets that don't support atomics b… 

    …y removing a #[cfg(target_has_atomic = ptr)]
    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    2012d4b View commit details
    Browse the repository at this point in the history

  6. chore: add tracking issue number to local waker feature

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0cb7a0a View commit details
    Browse the repository at this point in the history

  7. feat: impl AsRef<LocalWaker> for Waker.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f824373 View commit details
    Browse the repository at this point in the history

  8. chore: fix ci failures

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    093f80b View commit details
    Browse the repository at this point in the history

  9. fix: change issue number of waker_getters from #87021 to #96992.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ad28f75 View commit details
    Browse the repository at this point in the history

  10. chore: add and !Sync impls for LocalWaker as a stability guarantee.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    3e373f5 View commit details
    Browse the repository at this point in the history

  11. doc: update thread safety explanation for RawWakerVTable and RawWaker.

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    a8e71f2 View commit details
    Browse the repository at this point in the history

  12. fix: Apply suggestions from code review 

    Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
    @tvallotton @Mark-Simulacrum
    tvallotton and Mark-Simulacrum committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    c67a446 View commit details
    Browse the repository at this point in the history

  13. docs: remove recommendations to use LocalWaker in stable API document… 

    …ation
    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    eccb5e7 View commit details
    Browse the repository at this point in the history

  14. chore: make method order consistent with waker

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    7c6a9cb View commit details
    Browse the repository at this point in the history

  15. refactor: make waker mandatory. 

    This also removes
* impl From<&Context> for ContextBuilder
* Context::try_waker()

The from implementation is removed because now that
wakers are always supported, there are less incentives
to override the current context. Before, the incentive
was to add Waker support to a reactor that didn't have
any.
    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    038c6e0 View commit details
    Browse the repository at this point in the history

  16. doc: fix some doctests after rebase

    @tvallotton
    tvallotton committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    180c68b View commit details
    Browse the repository at this point in the history