create LifetimeRes::Fresh firstly when lower lifetime binder
#119021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
bvanjoi
commented
Dec 16, 2023
| @@ -26,7 +26,7 @@ LL | f2(|_: (), _: ()| {}); | |||
| | | | |||
| | expected due to this | |||
| | | |||
| = note: expected closure signature `for<'a, 'b> fn(&'a (), &'b ()) -> _` | |||
| = note: expected closure signature `for<'b, 'a> fn(&'a (), &'b ()) -> _` | |||
There was a problem hiding this comment.
This seems acceptable. Alternatively, we could sort this before displaying the diagnostics?
| let extra_lifetimes = self.resolver.take_extra_lifetime_params(binder); | ||
| debug!(?extra_lifetimes); | ||
| generic_params.extend(extra_lifetimes.into_iter().filter_map(|(ident, node_id, res)| { | ||
| params.extend(extra_lifetimes.into_iter().filter_map(|(ident, node_id, res)| { |
There was a problem hiding this comment.
Why does this fix the issue?
There was a problem hiding this comment.
An invocation of a def_id in extra_lifetimes occurs during lower_generic_params_mut. This rearrangement ensures that the def_id is not None.
| #![allow(incomplete_features)] | ||
| #![feature(non_lifetime_binders)] | ||
|
|
||
| type T = dyn for<V = A(&())> Fn(()); |
There was a problem hiding this comment.
We should probably just ban parameter defaults in non-lifetime binders before we get to AST->HIR lowering.
There was a problem hiding this comment.
Yes, I agree this is a promising approach. I'll give it a try.
|
in favor of #119042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118697
Rearrange the sequence to ensure that no null def id is read when lowering the lifetime.